Replace use of str::Lines with unicode-bidi-based iterator#124
Merged
jackpot51 merged 4 commits intopop-os:mainfrom Jun 9, 2023
Merged
Replace use of str::Lines with unicode-bidi-based iterator#124jackpot51 merged 4 commits intopop-os:mainfrom
str::Lines with unicode-bidi-based iterator#124jackpot51 merged 4 commits intopop-os:mainfrom
Conversation
3e0e980 to
5ab509e
Compare
Contributor
Author
|
I've resolved the conflict. |
str::lines with unicode-bidi-based iteratorstr::Lines with unicode-bidi-based iterator
jackpot51
approved these changes
Jun 9, 2023
15 tasks
StewartCanva
pushed a commit
to StewartCanva/cosmic-text
that referenced
this pull request
Jun 26, 2025
Replace use of `str::Lines` with `unicode-bidi`-based iterator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #74
Alternative to #102 which this PR adapts the logic from.
The motivation for making this public is that any consumer of cosmic text that needs to construct buffers by pushing buffer lines needs to be able to split text into paragraphs, and this prevents re-implementation of this logic by every downstream consumer of cosmic text.
Usage is seamless: