add Applicative methods#372
Merged
KingoftheHomeless merged 2 commits intopolysemy-research:masterfrom Jul 31, 2020
Merged
Conversation
KingoftheHomeless
requested changes
Jul 30, 2020
src/Polysemy/Internal.hs
Outdated
| {-# INLINE (*>) #-} | ||
|
|
||
| instance Monad (Sem f) where | ||
| return = pure |
Collaborator
There was a problem hiding this comment.
Could you also remove this definition?
Collaborator
There was a problem hiding this comment.
(That is, return = pure)
b3f63d5 to
a29b02c
Compare
- add Applicative `liftA2`, `(<*)`, and `(*>)` - resolves polysemy-research#368
- As directed in review of polysemy-research#372
a29b02c to
78140b1
Compare
KingoftheHomeless
approved these changes
Jul 31, 2020
Collaborator
KingoftheHomeless
left a comment
There was a problem hiding this comment.
Alright, nice. I'm satisfied.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Applicative
liftA2,(<*), and(*>)as directed in issue #368 .