Make interpretH and friends expose Monad on existential m#333
Merged
KingoftheHomeless merged 8 commits intopolysemy-research:masterfrom Jun 17, 2020
Merged
Conversation
In the process replace the existentially quantified parameter `m` of the Weaving with a parameter `r` and use `Sem r`.
Contributor
Author
|
Closes #304 |
This was referenced Apr 8, 2020
KingoftheHomeless
requested changes
Apr 8, 2020
Collaborator
KingoftheHomeless
left a comment
There was a problem hiding this comment.
Thanks for taking the time to go through this!
There are some additional changes you've made that I disagree with; some more than others. If you want to keep them, you'll have to convince me they're worth it.
There's also the question if we should change the type signatures of interpret and intercept to also specify that the provided m is Sem r0/a monad for symmetry (rather than usefulness). Either's fine for me.
65db238 to
bbf93d3
Compare
e71ff72 to
70aae42
Compare
KingoftheHomeless
requested changes
Jun 16, 2020
Collaborator
KingoftheHomeless
left a comment
There was a problem hiding this comment.
Thank you! All that remains now are some stylistic choices, a minor inconsistency, and an update in documentation.
KingoftheHomeless
approved these changes
Jun 17, 2020
Collaborator
KingoftheHomeless
left a comment
There was a problem hiding this comment.
All good! Thanks for this!
googleson78
added a commit
that referenced
this pull request
Jun 17, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the process replace the existentially quantified parameter
mof theWeaving with a parameter
rand useSem r.See also https://github.com/polysemy-research/polysemy/compare/master...A1kmm:weavingdetails-sem-experiment?expand=1 for this change broken down into smaller commits.