CMake improvement (moving generated sources out of sources directories) #1726
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrick96
added a commit
to patrick96/polybar
that referenced
this pull request
Apr 7, 2019
The settings.hpp file is now generated in the build folder and doesn't need to be included in the gitignore Ref polybar#1726
patrick96
added a commit
that referenced
this pull request
Apr 8, 2019
The settings.hpp file is now generated in the build folder and doesn't need to be included in the gitignore Ref #1726
doronbehar
pushed a commit
to doronbehar/polybar
that referenced
this pull request
Jun 16, 2019
doronbehar
pushed a commit
to doronbehar/polybar
that referenced
this pull request
Jun 16, 2019
The settings.hpp file is now generated in the build folder and doesn't need to be included in the gitignore Ref polybar#1726
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a proposition to move auto-generated files in build directory.
The problem with generating sources in sources directories is that it may cause problem when the compilation mode (Release; Debug; …) is changed without cleaning.
Furthermore, some IDEs that support CMake create a build directory per compilation mode, so the project directory has the following architecture:
With generated sources in the sources directories when I change from Debug to Release, cmake doesn't regenerate the setting file since it already exists but if you move the generated files in the build directory the problem disappears.