Misc Refactoring #1553
Merged
Misc Refactoring #1553
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ba995b2 to
55c41a7
Compare
55c41a7 to
e29d2f3
Compare
NBonaparte
reviewed
Jan 8, 2019
e29d2f3 to
dc62ae9
Compare
Member
Author
|
Hey @NBonaparte can we get this merged? |
The polybar executable with RelWithDebInfo gets over 100MB. And there really isn't any reason to have users install such huge executables. Release build type gives you approx. 3.6M executables Fixes polybar#1497
There isn't a single .c file in the project. It just added bloat
Each directory is responsible for ignoring files
Does basically the same as build.sh
Is exactly the same label_t
The settings.hpp file is now generated in the build folder and doesn't need to be included in the gitignore Ref polybar#1726
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I completed some refactoring tasks in a single PR, so this is going to be rebased.
I used a single PR because it would take a lot longer to open 5 PRs and have them reviewed and the changes are small enough for them not to interfere with each other too much.
So here's what I did:
Releasethe default build type. This reduces the filesize from over 100M to 3. Fixes Size of polybar binary on Ubuntu Cosmic #1497icon_tbecause it's the same aslabel_tIf you'd rather have each change in its own PR, let me know.