controller: Print error for duplicate modules #1534
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lomadriel
requested changes
Jun 4, 2019
Before if you wanted to iterate over all loaded modules you had to first iterate over all blocks and then over their modules even if you didn't care about alignment.
fceae58 to
d5ba601
Compare
Lomadriel
requested changes
Aug 6, 2019
Member
Lomadriel
left a comment
There was a problem hiding this comment.
x11/types.hppis unused incontroller.cpp
Should we fix #412 before merging this?
Since we deprecate using two time the same module, I think we need to promote an alternative which is not copy/paste.
I was thinking about just doing that:
[module/a]
…
[module/b]
inherit = module/bbut it doesn't work if module a is also using inheriting.
Member
Author
I don't think so. We only prohibit having the exact same module in the bar multiple times. I don't think anyone even has that in their config since they will display the exact same thing. You can still have the same module type multiple times. |
Member
Indeed that's true. |
d5ba601 to
16af42a
Compare
You can't use the same name twice inside the module lists E.g. modules-left = a b c modules-center = a modules-right = b would print an error. We only print an error for now because we don't want to break existing configs. But in the future this should be properly enforced.
16af42a to
b6d670c
Compare
patrick96
added a commit
to patrick96/polybar
that referenced
this pull request
Oct 27, 2019
Some people use text modules instead of the `separator` key in the bar section to better configure the separator (colors, fonts). Since we disallowed the same module being used multiple times in polybar#1534, this will now print an error message. This should help with this a bit. Ref polybar#1913
doronbehar
added a commit
to doronbehar/polybar
that referenced
this pull request
Nov 13, 2019
…eaudio-port * 'master' of https://github.com/polybar/polybar: (37 commits) github: Add subreddit as contact link aur: Update maintainer Update PKGBUILD for 3.4.1 ipc: Remove unused global setting build: Move all possible variables into settings.cpp fix(http): Pass char* as CURLOPT_USERAGENT build: Move non-macro variables into settings.cpp Update spec file clang-format bar: Make module separator a label build: drop python2 fix(build): Ignore noexcept-type for malloc_ptr_t travis: update to bionic fix(backlight): Use 'brightness' with amdgpu_bl0 fix(bar): Configure window before remapping controller: Print error for duplicate modules (polybar#1534) feat(xworkspaces): Support occupied workspaces (polybar#882) temperature: Use format-warn at warn-temperature not after (polybar#1897) feat(pulse): Show volume in decibels (polybar#1894) fix(ipc): Update bar when making bar visible ...
patrick96
added a commit
to patrick96/polybar
that referenced
this pull request
Jan 7, 2020
Functionality-wise reverts the changes from polybar#1534 In polybar#1907 we have decided to allow the same module to appear multiple times (and deliver actions to all matching modules). But since that PR will likely take longer to get merged, I want to remove the error from polybar because the message it prints isn't really true anymore.
patrick96
added a commit
that referenced
this pull request
Jan 12, 2020
Functionality-wise reverts the changes from #1534 In #1907 we have decided to allow the same module to appear multiple times (and deliver actions to all matching modules). But since that PR will likely take longer to get merged, I want to remove the error from polybar because the message it prints isn't really true anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can't use the same name twice inside the module lists
E.g.
would print an error.
We only print an error for now because we don't want to break existing
configs. But in the future this should be properly enforced.
This is in preparation for fixing #1172, because I plan on making modules uniquely identifiable by their name.