Fix indentation parsing#830
Merged
Merged
Conversation
Inline snapshot testing attempts to figure out the indentation width of a file by finding the first line with whitespace and grabbing the prefix of whitespace. While this works fine if you trim whitespace from whitespace-only lines, it breaks if you do not, because a line of the form: ``` " \n" ``` Will currently match in its entirety and incorporate the newline into the indentation. This PR fixes this by picking the first indented line that contains non-whitespace characters, instead.
mbrandonw
approved these changes
Feb 1, 2024
JustasL
added a commit
to vinted/swift-snapshot-testing
that referenced
this pull request
May 28, 2024
* main: Make ViewImageConfig Sendable (pointfreeco#850) Added mention of, and link to plugin SnapshotVision. (pointfreeco#848) Run swift-format Register test observer in main queue (pointfreeco#834) Ability to remove inline snapshots (pointfreeco#844) Bump swift-syntax to 5.10.0 (pointfreeco#836) Fix indentation parsing (pointfreeco#830) Fixing wkWebView.takeSnapshot with Xcode 14 & 15 (pointfreeco#692) Run swift-format Non-Metal based perceptual image comparison (pointfreeco#666)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inline snapshot testing attempts to figure out the indentation width of a file by finding the first line with whitespace and grabbing the prefix of whitespace. While this works fine if you trim whitespace from whitespace-only lines, it breaks if you do not, because a line of the form:
Will currently match in its entirety and incorporate the newline into the indentation.
This PR fixes this by picking the first indented line that contains non-whitespace characters, instead.