image/directory: store manifest and signature with digest algorithm prefix#535
Merged
Merged
Conversation
This was referenced Dec 8, 2025
podmanbot
pushed a commit
to podmanbot/buildah
that referenced
this pull request
Dec 8, 2025
|
✅ A new PR has been created in buildah to vendor these changes: podman-container-tools/buildah#6577 |
Contributor
Author
|
@mtrmac PTAL |
mtrmac
reviewed
Dec 9, 2025
mtrmac
left a comment
Contributor
There was a problem hiding this comment.
These changes LGTM, but usesNonSHA256Digest also needs updating.
podmanbot
pushed a commit
to podmanbot/buildah
that referenced
this pull request
Dec 9, 2025
Contributor
Author
@mtrmac added along with additional version tests for manifest and signatures. PTAL. |
mtrmac
reviewed
Dec 9, 2025
mtrmac
left a comment
Contributor
There was a problem hiding this comment.
Thanks! Code LGTM.
I’d prefer another test extension, but I don’t think it’s really blocking. Let me know.
mtrmac
reviewed
Dec 9, 2025
mtrmac
left a comment
Contributor
There was a problem hiding this comment.
LGTM, merge whenever ready.
Refactor the TestVersionAssignment blob tests to use a function-based approach instead of inline code. This prepares the test structure for adding manifest and signature tests in subsequent commits. The loop over algorithms is moved outside the put function for better code organization. Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>
When storing manifests with non-canonical digest algorithms (e.g., sha512), store the manifest file under the provided digest algorithm with an algorithm prefix (e.g., "sha512-abc.manifest.json" instead of just "abc.manifest.json"). SHA256 (canonical) digests continue to be stored without a prefix for backward compatibility. Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>
When storing signatures with non-canonical digest algorithms (e.g., sha512), store the signature file under the provided digest algorithm with an algorithm prefix (e.g., "sha512-abc.signature-1" instead of just "abc.signature-1"). SHA256 (canonical) digests continue to be stored without a prefix for backward compatibility. Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>
mtrmac
approved these changes
Dec 9, 2025
Contributor
Author
@mtrmac I don't have merge rights here, so maybe you or someone from @containers/container-libs-maintainers could take care of it please. |
podmanbot
pushed a commit
to podmanbot/buildah
that referenced
this pull request
Dec 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see individual commits for manifestPath and signaturePath