Skip to content

Use $BINDIR as the default helper binary directory on Windows#496

Merged
Luap99 merged 1 commit into
podman-container-tools:mainfrom
l0rd:win-default-helper-binaries
Nov 26, 2025
Merged

Use $BINDIR as the default helper binary directory on Windows#496
Luap99 merged 1 commit into
podman-container-tools:mainfrom
l0rd:win-default-helper-binaries

Conversation

@l0rd

@l0rd l0rd commented Nov 26, 2025

Copy link
Copy Markdown
Contributor

The default helper binary directory on Windows was hardcoded. However the new user-scope installer deploys the binaries on a distinct directory. As a consequence podman machine start fails because gvproxy/winssh-proxy cannot be found.

This problem affects Hyper-V, not WSL.

In this fix we changed default to $BINDIR that is interpreted by FindHelperBinaries() as the directory where podman is located.

Fixes podman-container-tools/podman#27603

The default helper binary directory on Windows was hardcoded. However
the new user-scope installer deploys the binaries on a distinct
directory. As a consequence `podman machine start` fails because
gvproxy/winssh-proxy cannot be found.

This problem affects Hyper-V, not WSL.

To fix the problem we are using $BINDIR that is used by the function
FindHelperBinaries to look in the directory where podman is located.

Fixes podman-container-tools/podman#27603

Signed-off-by: Mario Loriedo <mario.loriedo@gmail.com>
@github-actions github-actions Bot added the common Related to "common" package label Nov 26, 2025
podmanbot pushed a commit to podmanbot/buildah that referenced this pull request Nov 26, 2025
@podmanbot

Copy link
Copy Markdown

✅ A new PR has been created in buildah to vendor these changes: podman-container-tools/buildah#6539

@Luap99 Luap99 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Luap99 Luap99 merged commit baac55b into podman-container-tools:main Nov 26, 2025
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

common Related to "common" package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

defaultHelperBinariesDir doesn't play well with new Podman installer on Windows

3 participants