Use $BINDIR as the default helper binary directory on Windows#496
Merged
Luap99 merged 1 commit intoNov 26, 2025
Merged
Conversation
The default helper binary directory on Windows was hardcoded. However the new user-scope installer deploys the binaries on a distinct directory. As a consequence `podman machine start` fails because gvproxy/winssh-proxy cannot be found. This problem affects Hyper-V, not WSL. To fix the problem we are using $BINDIR that is used by the function FindHelperBinaries to look in the directory where podman is located. Fixes podman-container-tools/podman#27603 Signed-off-by: Mario Loriedo <mario.loriedo@gmail.com>
podmanbot
pushed a commit
to podmanbot/buildah
that referenced
this pull request
Nov 26, 2025
|
✅ A new PR has been created in buildah to vendor these changes: podman-container-tools/buildah#6539 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The default helper binary directory on Windows was hardcoded. However the new user-scope installer deploys the binaries on a distinct directory. As a consequence
podman machine startfails because gvproxy/winssh-proxy cannot be found.This problem affects Hyper-V, not WSL.
In this fix we changed default to
$BINDIRthat is interpreted byFindHelperBinaries()as the directory where podman is located.Fixes podman-container-tools/podman#27603