Possible lint fix for platform.go#427
Merged
mtrmac merged 1 commit intoOct 31, 2025
Merged
Conversation
podmanbot
pushed a commit
to podmanbot/buildah
that referenced
this pull request
Oct 30, 2025
|
✅ A new PR has been created in buildah to vendor these changes: podman-container-tools/buildah#6462 |
|
Packit jobs failed. @containers/packit-build please check. |
mtrmac
reviewed
Oct 30, 2025
mtrmac
left a comment
Contributor
There was a problem hiding this comment.
I agree this would fix the warning, but semantically that reads wrong — the primary documentation of the field is not a part of the deprecation message (and should not be included in linter/compiler output warning about the deprecation).
I think the right fix would be to add an empty comment line above the deprecation paragraph, e.g.
// PlatformPolicy controls the behavior of image-platform matching.
+ //
// Deprecated: new code should use define.PlatformPolicy directly.
Contributor
Author
|
@mtrmac thanks for the suggestion, I'll give that a go. |
3b6b63e to
290cf80
Compare
podmanbot
pushed a commit
to podmanbot/buildah
that referenced
this pull request
Oct 31, 2025
This PR: podman-container-tools#425 was barking about deprecation notices not being properly setup. I think this cures it. Signed-off-by: tomsweeneyredhat <tsweeney@redhat.com>
290cf80 to
caf2985
Compare
podmanbot
pushed a commit
to podmanbot/buildah
that referenced
this pull request
Oct 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR: #425 was barking about deprecation notices not being properly setup. I think this cures it. I just made the "Deprecation" comment be the leading line of the comment.