Prevent possible data race in access to Timer::_periodicInerval#646
Merged
aleks-f merged 1 commit intopocoproject:developfrom Jan 26, 2015
Merged
Prevent possible data race in access to Timer::_periodicInerval#646aleks-f merged 1 commit intopocoproject:developfrom
aleks-f merged 1 commit intopocoproject:developfrom
Conversation
Member
|
postponing this for 1.6.1 |
aleks-f
added a commit
that referenced
this pull request
Jan 26, 2015
Prevent possible data race in access to Timer::_periodicInerval
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I have another Helgrind report. This time it involves access to Timer::_periodicInterval.
In Timer::run() there is one unprotected read of this variable.
As alternative to the proposed patch, this would also work:
Or this, which only protects the read from _periodicInterval. If my understanding is right, _nextInvocation does not need synchronization, as it is only accessed by the timer thread itself:
Thanks,
Adriaan