Conversation
Closed
Contributor
There was a problem hiding this comment.
Pull request overview
Adds / improves clang-cl support in CMake-based builds by introducing a compiler/cross-compile selection module, tightening some Windows/Clang linking behavior, and validating the setup via CI.
Changes:
- Introduces
POCO_COMPILER/POCO_CROSS_COMPILECMake options for selecting compilers and cross-compilation targets (including clang-cl handling). - Updates Windows SSL socket implementation declarations to use
overridefor better clang-cl/MSVC compatibility. - Adds a Windows clang-cl CI job and prints selected compiler/toolchain information during configuration.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
cmake/PocoCompilerSelect.cmake |
New pre-project() compiler/cross-compile selection logic + clang-cl host-target auto-detection |
CMakeLists.txt |
Includes the new compiler select module early and prints compiler selection details |
NetSSL_Win/include/Poco/Net/SecureStreamSocketImpl.h |
Adds override specifiers to virtual overrides (helps clang-cl catch mismatches) |
Net/include/Poco/Net/Net.h |
Adjusts symbol-forcing macro conditional to include Clang |
.github/workflows/ci.yml |
Adds a Windows clang-cl (Ninja+CMake) build/test job |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
matejk
pushed a commit
that referenced
this pull request
Feb 14, 2026
* feat(build): clang-cl support #5195 * Update cmake/PocoCompilerSelect.cmake Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * usce NATURAL ORDER on android Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.