fix(cmake): unbundled build failure with disabled features (#5196)#5197
Merged
matejk merged 3 commits intopoco-1.15.1from Feb 11, 2026
Merged
fix(cmake): unbundled build failure with disabled features (#5196)#5197matejk merged 3 commits intopoco-1.15.1from
matejk merged 3 commits intopoco-1.15.1from
Conversation
bf58b77 to
64f5fe6
Compare
…t configure time.
matejk
added a commit
that referenced
this pull request
Feb 12, 2026
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #5196: CMake build failure when using
POCO_UNBUNDLED=ONwith features like PDF disabled (-DENABLE_PDF=OFF) and their corresponding system libraries not installed.find_package()for libraries that are actually needed by enabled features. Previously, disabled features still triggered unnecessary (and sometimes failing)find_package()calls.return()with warning whenPOCO_UNBUNDLEDis set andPNG::PNGtarget doesn't exist, preventing thetarget_link_librarieserror on a missing target.POCO_UNBUNDLEDforcesPOCO_SQLITE_UNBUNDLED=ON, so checkingPOCO_SQLITE_UNBUNDLEDinside thePOCO_UNBUNDLEDbranch was always true. Restored the correct 3-branch structure.ENABLE_FOUNDATION=ONsince all components depend on it.Test plan
cmake -DENABLE_PDF=OFF -DPOCO_UNBUNDLED=ONsucceeds without libpng installedcmake -DENABLE_DATA_SQLITE=OFF -DPOCO_SQLITE_UNBUNDLED=ONsucceeds without sqlite warningcmake -DENABLE_XML=OFF -DPOCO_UNBUNDLED=ONsucceeds without libexpat installedcmake -DENABLE_PDF=ON -DPOCO_UNBUNDLED=ONcorrectly requires system libpngcmake -DENABLE_FOUNDATION=OFFbuilds Foundation anyway