fix(Net): Handle negative available() return in receiveBytes (#4537)#5127
Merged
fix(Net): Handle negative available() return in receiveBytes (#4537)#5127
Conversation
Co-Authored-By: Andrew Auclair <mightymalakai33@gmail.com>
a030e13 to
7801fc6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #4537 - On Windows, sending UDP to a closed port causes
available()to return -1 due to ICMP "connection reset" error. When this negative value was used for buffer allocation inreceiveBytes(Buffer&), it causedstd::bad_array_new_lengthcrash.Changes:
SocketImpl::receiveBytes(Buffer&): Check for negativeavailable()and throwIOExceptionSocketProactor: Checkavailable() > 0before processing, with explicit cast to avoid signed/unsigned comparisontestClosedPortErrorto verify the fixSupersedes #4539 (implements the maintainer's preferred approach of fixing callers rather than having
available()throw).