Throw Error in Socket::available if Socket Error Occurs #4539
Closed
andrewauclair wants to merge 1 commit intopocoproject:mainfrom
Closed
Throw Error in Socket::available if Socket Error Occurs #4539andrewauclair wants to merge 1 commit intopocoproject:mainfrom
andrewauclair wants to merge 1 commit intopocoproject:mainfrom
Conversation
aleks-f
requested changes
Jul 29, 2024
Member
aleks-f
left a comment
There was a problem hiding this comment.
I generally don't like just querying for something throwing an exception.
I would prefer available remaining as is, and instead document that negative value means invalid socket and fix all the affected code to take that into account (this may be an exception where it makes sense).
Contributor
Author
|
I can change it back and throw exceptions in places that poco calls available. If that's what you want. I do feel that the exception forces the issue better. But I agree with your statement about querying functions. |
Contributor
|
Superseded by #5127, which implements the approach suggested in the review (fix callers instead of having |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes to help address the issues I was seeing in #4537. This change makes
SocketImpl::availablethrow an error exception if the result ofrecvfromis negative and there was a socket error for UDP sockets. This will correctly inform the calling code that the socket is invalid and needs to be reset. This also fixes the issue withreceiveBytesthrowingstd::bad_array_new_lengthbecause it will instead throw a Poco exception first when callingavailable.