Skip to content

fix(CMake): Select MSVC runtime library with variable CMAKE_MSVC_RUNTIME_LIBRARY (fixes #4817)#4823

Merged
matejk merged 3 commits intomainfrom
4817_select-runtime-with-cmake-msvc-runtime-library
Dec 27, 2024
Merged

fix(CMake): Select MSVC runtime library with variable CMAKE_MSVC_RUNTIME_LIBRARY (fixes #4817)#4823
matejk merged 3 commits intomainfrom
4817_select-runtime-with-cmake-msvc-runtime-library

Conversation

@matejk
Copy link
Copy Markdown
Contributor

@matejk matejk commented Dec 18, 2024

Use CMake features to select MSVC runtime library with CMAKE_MSVC_RUNTIME_LIBRARY instead of modifying compiler options.

Resolves #4817

@matejk
fix(CMake): Select MSVC runtime library with variable CMAKE_MSVC_RUNT…
870a3e9 
…IME_LIBRARY instead of modifying compiler flags.
@matejk matejk added platform_specific cmake Related to cmake build system labels Dec 18, 2024
@matejk matejk added this to the Release 1.14.1 milestone Dec 18, 2024
@matejk matejk self-assigned this Dec 18, 2024
@matejk matejk force-pushed the 4817_select-runtime-with-cmake-msvc-runtime-library branch from 66d1516 to 17d5ca1 Compare December 18, 2024 13:20
@matejk matejk mentioned this pull request Dec 20, 2024
Closed
@matejk matejk merged commit c9dc1f9 into main Dec 27, 2024
@matejk matejk deleted the 4817_select-runtime-with-cmake-msvc-runtime-library branch December 27, 2024 11:47
matejk added a commit that referenced this pull request Dec 27, 2024
@matejk
fix(CMake): Select MSVC runtime library with variable CMAKE_MSVC_RUNT…
3971ad2 
…IME_LIBRARY (fixes #4817) (#4823)

* fix(CMake): Select MSVC runtime library with variable CMAKE_MSVC_RUNTIME_LIBRARY instead of modifying compiler flags.

* enh(CI): Add static and MT MSVC builds.

* fix(CMake): Correct TestLibrary DLL name when building with MSVC
@Krzmbrzl Krzmbrzl mentioned this pull request Feb 21, 2025
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@matejk matejk

Labels

cmake Related to cmake build system platform_specific

Projects

No open projects
1.14
Status: Done

Milestone

Release 1.14.1

Development

Successfully merging this pull request may close these issues.

Windows Static Build Problem / Changed behaviour of POCO_MT (CMake 3.15)

1 participant

@matejk