MongoDB: use constants instead of typed enum in OpMsgMessage#4822
Merged
MongoDB: use constants instead of typed enum in OpMsgMessage#4822
Conversation
…d improper binary serialisation (int instead of unsigned char).
matejk
added a commit
that referenced
this pull request
Dec 17, 2024
* fix(MongoDB): Use constants for payload types instead of enum to avoid improper binary serialisation with some compilers (int instead of unsigned char). * enh(MongoDB): Minor code improvements to use string literals.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some compilers improperly use
BinaryWriter::operator << (int)instead ofunsigned charfor a typed enum, causing the binary structure to become invalid.The enum is replaced with constants.
See #4810 for discussion.