Attempting to load a passphrase-protected key should not prompt cin#4799
Closed
nyashbox wants to merge 2 commits intopocoproject:mainfrom
Closed
Attempting to load a passphrase-protected key should not prompt cin#4799nyashbox wants to merge 2 commits intopocoproject:mainfrom
nyashbox wants to merge 2 commits intopocoproject:mainfrom
Conversation
Contributor
|
This PR seems to solve the problem with empty password on macOS (OpenSSL 3.4.0). However, on Ubuntu 24.10 (OpenSSL 3.3.1), the example prompts for the password with or without the code change. |
Member
|
Let's move this to 1.15. |
Contributor
|
Superseded by #5128, which provides a more complete fix that works on both macOS and Linux. The issue with PR #4799 was that it only changed The fix in #5128 always provides the callback, which correctly handles empty passwords by returning 0 (no password), causing OpenSSL to throw a proper error. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4627