Skip to content

fix(SecureSocket): Refactor detection of timeout when reading, writing and handshaking#4510

Merged
matejk merged 3 commits intodevelfrom
3725_secure-socket-timeout-too-long
Mar 26, 2024
Merged

fix(SecureSocket): Refactor detection of timeout when reading, writing and handshaking#4510
matejk merged 3 commits intodevelfrom
3725_secure-socket-timeout-too-long

Conversation

@matejk
Copy link
Copy Markdown
Contributor

@matejk matejk commented Mar 26, 2024

Resolves #3725

@matejk matejk requested a review from aleks-f March 26, 2024 10:43
@matejk matejk force-pushed the 3725_secure-socket-timeout-too-long branch from f45bc38 to 5086cb3 Compare March 26, 2024 10:44
}

X509* pCert = SSL_get_peer_certificate(_pSSL);
::X509* pCert = ::SSL_get_peer_certificate(_pSSL);

Check failure

Code scanning / CodeQL

Certificate not checked

This call to SSL_get_peer_certificate is not followed by a call to SSL_get_verify_result.
@matejk matejk merged commit 482c066 into devel Mar 26, 2024
matejk added a commit that referenced this pull request Mar 26, 2024
…g and handshaking (#4510)

* fix(SecureSocket): Refactor detection of timeout when reading, writing or handshaking. (#3725)

* enh(SecureSocket): some trivial C++17 modernisation changes.

* chore: indentation and compiler warning

---------

Co-authored-by: Alex Fabijanic <alex@pocoproject.org>
@matejk matejk deleted the 3725_secure-socket-timeout-too-long branch March 26, 2024 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

secure socket receiveTimeout throwing after configured timeout * 2

2 participants