* Fix JSON unicode handling#45
Merged
aleks-f merged 2 commits intopocoproject:developfrom Dec 29, 2012
Merged
Conversation
Contributor
Author
|
I'm not an Unicode expert, please review if the test case I made is correct. |
Member
|
I reverted this. The pull tests do pass but it's somewhat of a half-solution because it does not work for the OP case - the string ends up being internally converted into ???. It probably has to do with the current system code page but I have no time right now, maybe Franky can review it and come up with a more comprehensive set of tests. |
aleks-f
added a commit
that referenced
this pull request
Dec 30, 2012
…nicode""" This reverts commit 86647bd.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix by tolauyoume
see http://pocoproject.org/forum/viewtopic.php?f=10&t=5686