SplitterChannel addChannel - Prevent Duplicate Channels#4270
Merged
aleks-f merged 1 commit intopocoproject:develfrom Nov 21, 2023
Merged
SplitterChannel addChannel - Prevent Duplicate Channels#4270aleks-f merged 1 commit intopocoproject:develfrom
aleks-f merged 1 commit intopocoproject:develfrom
Conversation
…internal vector. This prevents issues where the channel is accidentally added twice but only removed once because removeChannel stops at the first result.
aleks-f
pushed a commit
that referenced
this pull request
Nov 23, 2023
SplitterChannel::addChannel() should only add a channel once to the internal vector. This prevents issues where the channel is accidentally added twice but only removed once because removeChannel stops at the first result. (#4270)
aleks-f
pushed a commit
that referenced
this pull request
Nov 27, 2023
SplitterChannel::addChannel() should only add a channel once to the internal vector. This prevents issues where the channel is accidentally added twice but only removed once because removeChannel stops at the first result. (#4270)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure that the SplitterChannel addChanel function will only add the channel to the internal vector once. This prevents issues where the channel is accidentally added twice but only removed once because removeChannel stops at the first result.