Virtualize ServerApplication::handlePidFile()#4223
Conversation
|
Why doesn't |
@pavledragisic change it, but it also requires changes on our side (devs, dispatcher and s7server) so either align it on our side or create an issue there |
|
@obiltschnig now that I think about it, I'd keep both versions. The string version is convenient because there's no need to create Option on the call side |
|
Then at least also add an |
alright, @pavledragisic do it like that |
|
@obiltschnig after a bit more thinking, how about this instead: template <typename T>
void OptionSet::replaceHandler(const std::string& opt, T* pObj, Callback<T> func)That is really what we need - to tell the |
|
If that's all you need, then how about just making |
virtualizing will work; at this time, I would limit it to handlePidFile only and I would also like to move it out of #ifdef FAMILY_UNIX, so that it is available on all platforms |
@pavledragisic do it like this ^ discard current changes in this branch, move this function out of #ifdef, and make it virtual. We then have to override it in our processes that require strict PID creation timing |
* feat(OptionSet): Add replaceOption() #4181 * revert changes #4181 * feat: make ServerApplication::handlePidFile virtual #4181 * move handlePidFile() out of ifdef #4181 * fix(ServerApplication): move handlePidFile() out of all ifdefs #4181 --------- Co-authored-by: Pavle <pavle@debian-gnu-linux-11.localdomain> Co-authored-by: Aleksandar Fabijanic <aleks-f@users.noreply.github.com>
* feat(OptionSet): Add replaceOption() #4181 * revert changes #4181 * feat: make ServerApplication::handlePidFile virtual #4181 * move handlePidFile() out of ifdef #4181 * fix(ServerApplication): move handlePidFile() out of all ifdefs #4181 --------- Co-authored-by: Pavle <pavle@debian-gnu-linux-11.localdomain> Co-authored-by: Aleksandar Fabijanic <aleks-f@users.noreply.github.com>
No description provided.