Skip to content

add missing check when activerecord is enabled#4138

Merged
aleks-f merged 1 commit intopocoproject:develfrom
stkw0:devel
Sep 24, 2023
Merged

add missing check when activerecord is enabled#4138
aleks-f merged 1 commit intopocoproject:develfrom
stkw0:devel

Conversation

@stkw0
Copy link
Copy Markdown
Contributor

@stkw0 stkw0 commented Sep 4, 2023

If ENABLE_ACTIVERECORD is on, XML should also be enabled.

Building without XML support produces some errors like:

ld: ActiveRecord/Compiler/CMakeFiles/ActiveRecordCompiler.dir/src/Parser.cpp.o:(.data.rel.ro._ZTVN4Poco12ActiveRecord8Compiler6ParserE[_ZTVN4Poco12ActiveRecord8Compiler6ParserE]+0x170): undefined reference to `non-virtual thunk to Poco::XML::DefaultHandler::error(Poco::XML::SAXException const&)'
ld: ActiveRecord/Compiler/CMakeFiles/ActiveRecordCompiler.dir/src/Parser.cpp.o:(.data.rel.ro._ZTVN4Poco12ActiveRecord8Compiler6ParserE[_ZTVN4Poco12ActiveRecord8Compiler6ParserE]+0x178): undefined reference to `non-virtual thunk to Poco::XML::DefaultHandler::fatalError(Poco::XML::SAXException const&)'

@aleks-f aleks-f added this to the Release 1.13.0 milestone Sep 24, 2023
@aleks-f aleks-f merged commit b61d63d into pocoproject:devel Sep 24, 2023
aleks-f pushed a commit that referenced this pull request Nov 23, 2023
@stkw0 @aleks-f
add missing check when activerecord is enabled (#4138)
f607b01
aleks-f pushed a commit that referenced this pull request Nov 27, 2023
@stkw0 @aleks-f
add missing check when activerecord is enabled (#4138)
d1a3c6c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

buildsystem

Projects

None yet

Milestone

Release 1.13.0

Development

Successfully merging this pull request may close these issues.

2 participants

@stkw0 @aleks-f