Fix dead lock on Timer destructor#3987
Merged
aleks-f merged 1 commit intopocoproject:develfrom Mar 30, 2023
Merged
Conversation
Consider following situation. A class owns a timer. In destructor of that class we call .cancel() asynchronous on timer before it's destruction. Now timer is executing cancel in it's own internal thread, while it's doing that destructor of timer is called from owning class. Timer destructor enqueues stop notification. If that enqueue is happening just after while loop from cancel notification, stop notification is gonna be dropped and timer will never stop. fixes pocoproject#3986
aleks-f
pushed a commit
that referenced
this pull request
Mar 30, 2023
Consider following situation. A class owns a timer. In destructor of that class we call .cancel() asynchronous on timer before it's destruction. Now timer is executing cancel in it's own internal thread, while it's doing that destructor of timer is called from owning class. Timer destructor enqueues stop notification. If that enqueue is happening just after while loop from cancel notification, stop notification is gonna be dropped and timer will never stop. fixes #3986 Co-authored-by: Vojin Ilic <vilic@nvidia.com>
Contributor
Author
|
Should I also cherry pick this to 1.12.5 or will that be handled by who ever releases 1.12.5? |
vojinilic
pushed a commit
to vojinilic/poco
that referenced
this pull request
Apr 2, 2023
This reverts commit 39a8b9a.
vojinilic
pushed a commit
to vojinilic/poco
that referenced
this pull request
Apr 2, 2023
This reverts commit 5124431.
aleks-f
pushed a commit
that referenced
this pull request
Apr 4, 2023
aleks-f
pushed a commit
that referenced
this pull request
Apr 4, 2023
aleks-f
pushed a commit
that referenced
this pull request
Nov 27, 2023
Consider following situation. A class owns a timer. In destructor of that class we call .cancel() asynchronous on timer before it's destruction. Now timer is executing cancel in it's own internal thread, while it's doing that destructor of timer is called from owning class. Timer destructor enqueues stop notification. If that enqueue is happening just after while loop from cancel notification, stop notification is gonna be dropped and timer will never stop. fixes #3986 Co-authored-by: Vojin Ilic <vilic@nvidia.com>
aleks-f
pushed a commit
that referenced
this pull request
Nov 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consider following situation. A class owns a timer. In destructor of that class we call .cancel() asynchronous on timer before it's destruction. Now timer is executing cancel in it's own internal thread, while it's doing that destructor of timer is called from owning class. Timer destructor enqueues stop notification. If that enqueue is happening just after while loop from cancel notification, stop notification is gonna be dropped and timer will never stop.
fixes #3986