Pull requests should go to develop branch

Oops, my apologies. I've changed the Pull Request to base off of devel.

Hello @aleks-f I don't think our patch is the reason for the checks failing. I think the checks in the devel branch were failing before we committed.

Rebased with latest devel to see if that helps it pass checks

There seems to be a bug with the github checks.

Hi! I think, that problem a little bit more complicated than this PR. Please look at #3939
It's illegal to comare 1 with result of function which has void as a return param. My topic correct for openssl 1.0.2.
And this PR correct only for opennsl version where EVP_CIPHER_CTX_init has int as return param

Hello! Our patch does address the problem you mention. We use a C macro to test the OpenSSL version and handle both cases (one where the function returns void and one that returns an int).

Hello @aleks-f Do you know if our patch is acceptable for the 1.12.5 release?

Hello! Our patch does address the problem you mention. We use a C macro to test the OpenSSL version and handle both cases (one where the function returns void and one that returns an int).

Please, try build with openssl version 1.0.2. And you will see that in this version EVP_CIPHER_CTX returns void, and it will be a compile time error.
I have gotten it on solaris with openssl 1.0.2f

Hello @bas524,

We successfully compiled against OpenSSL 1.0.2k on CentOS 7. I agree that EVP_CIPHER_CTX_init returns void. I can't explain why you are getting compile errors on your Solaris system, but below I explain why our patch works:

#if OPENSSL_VERSION_NUMBER >= 0x10100000L
	if (1 != EVP_CIPHER_CTX_init(_pCtx))
		handleErrors(std::string("Envelope():EVP_CIPHER_CTX_init()"));
#else
	EVP_CIPHER_CTX_init(_pCtx);
#endif

The first line #if OPENSSL_VERSION_NUMBER >= 0x10100000L tests if the OpenSSL version is >= 1.1.0. If this is true, then we compile the version of EVP_CIPHER_CTX_init that returns an int.

Otherwise, we compile the version that returns void. This is true if OpenSSL version is 1.0.2, for example.

Hello @bas524,

We successfully compiled against OpenSSL 1.0.2k on CentOS 7. I agree that EVP_CIPHER_CTX_init returns void. I can't explain why you are getting compile errors on your Solaris system, but below I explain why our patch works:

#if OPENSSL_VERSION_NUMBER >= 0x10100000L
	if (1 != EVP_CIPHER_CTX_init(_pCtx))
		handleErrors(std::string("Envelope():EVP_CIPHER_CTX_init()"));
#else
	EVP_CIPHER_CTX_init(_pCtx);
#endif

The first line #if OPENSSL_VERSION_NUMBER >= 0x10100000L tests if the OpenSSL version is >= 1.1.0. If this is true, then we compile the version of EVP_CIPHER_CTX_init that returns an int.

Otherwise, we compile the version that returns void. This is true if OpenSSL version is 1.0.2, for example.

I'm sorry. I was wrong. It was my inattention.
Your fix is correct. I have reused it for PR with fixes for solaris