Use map from key to count instead of multiset#3885
Merged
aleks-f merged 2 commits intopocoproject:develfrom Jan 24, 2023
Merged
Use map from key to count instead of multiset#3885aleks-f merged 2 commits intopocoproject:develfrom
aleks-f merged 2 commits intopocoproject:develfrom
Conversation
c50bad9 to
c90a9cc
Compare
Contributor
Author
|
I added test XMLConfigurationTest::testManyKeys that reproduces the problem by enumerating 100K elements with the same name. |
aleks-f
pushed a commit
that referenced
this pull request
Nov 27, 2023
* Test that enumerates lots of elements with the same name
* Use map from key to count instead of multiset
Co-authored-by: Alexander Gololobov <{ID}+{username}@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We noticed slow performance of XMLConfiguration::enumerate when a node had lots of children with the same name. In this case std::multiset is not needed for assigning consequent indexes to children, std::map is better in terms of number allocations and memory consumption.