chore(Net) : correct spelling, remove some unused codes fix(SocketProactor) : missing adding sock to read pollset fix(DialogServer) : _lastCommands data race#3821
Merged
aleks-f merged 5 commits intopocoproject:develfrom Jul 11, 2023
Conversation
fix(CppUint) : RepeatedTest compile error
fix(SocketProactor) : missing adding sock to read pollset fix(DialogServer) : _lastCommands data race
Contributor
Author
|
I think it's missing adding socket to the read pollset here ( |
aleks-f
pushed a commit
that referenced
this pull request
Nov 23, 2023
…actor) : missing adding sock to read pollset fix(DialogServer) : _lastCommands data race (#3821) * chore(CppUnit) : style format and revise comment fix(CppUint) : RepeatedTest compile error * chore(CppUnit) : remove TestResult forward declare in RepeatedTest.h * chore(Net) : correct spelling, remove some unused codes fix(SocketProactor) : missing adding sock to read pollset fix(DialogServer) : _lastCommands data race
aleks-f
pushed a commit
that referenced
this pull request
Nov 27, 2023
…actor) : missing adding sock to read pollset fix(DialogServer) : _lastCommands data race (#3821) * chore(CppUnit) : style format and revise comment fix(CppUint) : RepeatedTest compile error * chore(CppUnit) : remove TestResult forward declare in RepeatedTest.h * chore(Net) : correct spelling, remove some unused codes fix(SocketProactor) : missing adding sock to read pollset fix(DialogServer) : _lastCommands data race
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.