Skip to content

Add an option to force the use of PollingDirectoryWatcherStrategy#2881

Merged
obiltschnig merged 3 commits intopocoproject:poco-1.10.0from
Ludorg:poco-1.10.0
Jan 17, 2020
Merged

Add an option to force the use of PollingDirectoryWatcherStrategy#2881
obiltschnig merged 3 commits intopocoproject:poco-1.10.0from
Ludorg:poco-1.10.0

Conversation

@Ludorg
Copy link
Copy Markdown
Contributor

@Ludorg Ludorg commented Jan 13, 2020

On Linux, inotfy does not work for network mounted volumes (such as NFS). See https://stackoverflow.com/questions/4231243/inotify-with-nfs

By adding flag POCO_DW_FORCE_POLLING in Foundation/Config.h, the use of PollingDirectoryWatcherStrategy is forced on Linux. This is not the same behavior as flag POCO_NO_INOTIFY which disables compilation of DirectoryWatcher.

@aleks-f
Copy link
Copy Markdown
Member

aleks-f commented Jan 14, 2020

This behavior (probably) applies to any shared FS, and is (probably) not Linux-specific on top of that. If my guesses are correct, flag should apply to any platform.

@Ludorg
Copy link
Copy Markdown
Contributor Author

Ludorg commented Jan 14, 2020

This behavior (probably) applies to any shared FS, and is (probably) not Linux-specific on top of that. If my guesses are correct, flag should apply to any platform.

OK, I will refactor this and propose a new pull request with the proposed behavior.

Add an option to force the use of PollingDirectoryWatcherStrategy
Should work on any platform
(Not Linux only)

See previous PR on this topic :
pocoproject#2881

On Linux, inotfy does not work for network volumes (such as NFS).

See https://stackoverflow.com/questions/4231243/inotify-with-nfs

By adding flag POCO_DW_FORCE_POLLING in Foundation/Config.h,
the use of PollingDirectoryWatcherStrategy is forced.

This is not the same behavior as flag POCO_NO_INOTIFY.
This only disables compilation of DirectoryWatcher.
Add an option to force the use of PollingDirectoryWatcherStrategy
Should work on any platform
(Not Linux only)

See previous PR on this topic :
pocoproject#2881

On Linux, inotfy does not work for network volumes (such as NFS).

See https://stackoverflow.com/questions/4231243/inotify-with-nfs

By adding flag POCO_DW_FORCE_POLLING in Foundation/Config.h,
the use of PollingDirectoryWatcherStrategy is forced.

This is not the same behavior as flag POCO_NO_INOTIFY.
This only disables compilation of DirectoryWatcher.
@Ludorg Ludorg changed the title add an option to force the use of PollingDirectoryWatcherStrategy on Linux add an option to force the use of PollingDirectoryWatcherStrategy Jan 15, 2020
@Ludorg Ludorg changed the title add an option to force the use of PollingDirectoryWatcherStrategy Add an option to force the use of PollingDirectoryWatcherStrategy Jan 15, 2020
@obiltschnig obiltschnig merged commit 6058f5d into pocoproject:poco-1.10.0 Jan 17, 2020
@obiltschnig obiltschnig added this to the Release 1.10.0 milestone Jan 17, 2020
@obiltschnig obiltschnig self-assigned this Jan 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants