Closed
Conversation
added 2 commits
October 18, 2019 18:34
1024 bits is deprecated / becoming insecure, and some configurations start to reject it, e.g. Debian 10 machines by default.
list of supported groups rather than a single curve only.
they did not support SSL_CTX_set1_group_lists under that name. Also carefully set defaults based on what is supported (as opposed to documented) according to OpenSSL version.
Member
|
merged into poco-1.10.1 (made 2048 curves optional, subject to config param). |
Author
|
@obiltschnig, you made using 2048 bit DH off by default. I wish to stress that:
For maximum compatibility with latest versions of connection peers, I recommend defaulting to 2048 bit DH. |
Member
|
I understand, but I don't want to potentially break existing code relying on the current behavior in a minor update. |
Author
|
Yes, that's a good point. |
Member
|
I also had to remove some ECDH groups, as not all OpenSSL builds seem to support them. The set I ended up with for OpenSSL 1.1.1 is "X448:X25519:P-521:P-384:P-256". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pushed by a poco-using client that would my web server would not let me connect to, I modernised a bit the default TLS configuration.