Redefine Poco assertions for static analysis#1315
Merged
obiltschnig merged 1 commit intopocoproject:developfrom Sep 14, 2016
Merged
Redefine Poco assertions for static analysis#1315obiltschnig merged 1 commit intopocoproject:developfrom
obiltschnig merged 1 commit intopocoproject:developfrom
Conversation
Static analyzers typically don't do cross-translation unit analysis, so they don't understand that most of the Poco::Bugcheck methods never return. Unfortunately, some of them also don't understand noreturn annotations (see e.g. http://en.cppreference.com/w/cpp/language/attributes), so decorating Bugcheck doesn't help. Instead redefine all the Poco assertion macros to just call abort() iff we're parsed by a known static analyzer.
Contributor
Author
|
Not sure if this is something you could consider for upstream. We're carrying a local patch which reduces false positives from static analyzers quite a lot. |
Contributor
Author
|
Friendly ping! |
Member
|
Was actually stumbling across the same issue lately ;-) |
Contributor
Author
|
Great, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Static analyzers typically don't do cross-translation unit analysis, so
they don't understand that most of the Poco::Bugcheck methods never
return.
Unfortunately, some of them also don't understand noreturn annotations
(see e.g. http://en.cppreference.com/w/cpp/language/attributes), so
decorating Bugcheck doesn't help.
Instead redefine all the Poco assertion macros to just call abort() iff
we're parsed by a known static analyzer.