You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
While this technically fixes#9529 (the warning no longer shows up when installing, which is what the issue was technically about), pnpm still makes usage of url.parse in other places, via @pnpm/nopt and @pnpm/npm-package-arg, and they haven't seen any commits in 3/4 years. Should I send PRs there too?
normalize-package-data is about to be deprecated though, efforts should be made to switch to @npmcli/package-json, but that's unrelated to the PR 👍
it looks like we can't use URL.canParse and therefore we can't update normalize-package-data, as pnpm supports node 18.12.0 and URL.canParse was added in node 18.17.0 🤔 what should i do?
In theory dropping Node.js up until 18.17 shouldn't affect a lot of users but it would be still considered a breaking change. But we are not ready yet to bump pnpm to v11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While this technically fixes #9529 (the warning no longer shows up when installing, which is what the issue was technically about),
pnpmstill makes usage ofurl.parsein other places, via@pnpm/noptand@pnpm/npm-package-arg, and they haven't seen any commits in 3/4 years. Should I send PRs there too?normalize-package-datais about to be deprecated though, efforts should be made to switch to@npmcli/package-json, but that's unrelated to the PR 👍Fixes #9529
Ref: npm/normalize-package-data#247