fix: remove usage of deprecated url.parse api#1
Merged
Conversation
This was referenced Jul 23, 2025
Author
|
it looks like the tests use ports from URLs like
|
Co-authored-by: Gar <gar+gh@danger.computer>
8e0bbbd to
51229b5
Compare
URL.parse instead of deprecated url.parse apiurl.parse api
Author
Member
|
We can try to switch to the original package. Looking at the commits in this repo, the fork was created to add support for aliases. npm also added support for aliases since then. |
Author
|
sadly, latest version from upstream requires node 18.17.0 and up. no idea if they actually use node >=18.17 features but the engines field is set that way |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
needed to solve pnpm/pnpm#9529
version
2.0.0of this package should be created and released after this gets merged