fix(publish): --config.unknown CLI options needs special handling when passing them to npm #9085
Closed
fix(publish): --config.unknown CLI options needs special handling when passing them to npm #9085
Conversation
|
💖 Thanks for opening this pull request! 💖 |
…n passing them to npm
873e398 to
4867e32
Compare
Member
|
Yes, this is probably OK. |
naruaway
commented
Feb 12, 2025
| } | ||
| } | ||
| // Convert Pnpm's "unknown config" form into regular form so that npm can understand it | ||
| args = args.map(a => a.replace(/^--config\./, '--')) |
Contributor
Author
There was a problem hiding this comment.
Note: I just realized that we need to make sure we should not apply this conversion after --. I'll fix later after getting some signal from maintainers
Contributor
Author
|
@zkochan Thanks for really quick response! I'll make sure handle edge cases and will add tests later today |
Contributor
Author
|
After some consideration, now I would prefer #9089 over this PR. Closing for now |
zkochan
pushed a commit
that referenced
this pull request
Feb 25, 2025
zkochan
pushed a commit
that referenced
this pull request
Feb 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix #9084
If this direction looks good, I can add tests
So far I quickly verified by modifying
dist/pnpm.cjsdirectly insidenode_modulesfor the corresponding place