fix: ERR_PNPM_TARBALL_EXTRACT when the URL's hash contains a slash#8761
Conversation
|
💖 Thanks for opening this pull request! 💖 |
zkochan
requested changes
Nov 17, 2024
| wantedDependency: { pref: string } | ||
| ): Promise<ResolveResult | null> { | ||
| if (!wantedDependency.pref.startsWith('http:') && !wantedDependency.pref.startsWith('https:')) { | ||
| if (!(wantedDependency.pref.startsWith('http:') || wantedDependency.pref.startsWith('https:'))) { |
Member
There was a problem hiding this comment.
why was this changed? it is unrelated to the fix
Contributor
Author
There was a problem hiding this comment.
Sorry, this is my own hobby. This writing is better for my understanding...
Contributor
There was a problem hiding this comment.
Copilot reviewed 3 out of 3 changed files in this pull request and generated no suggestions.
Comments skipped due to low confidence (2)
pnpm/test/install/misc.ts:574
- The test should verify that the package was correctly installed. Add an assertion to check the presence of the installed package.
expect(result.status).toBe(0)
resolving/tarball-resolver/src/index.ts:32
- Reassigning 'pref' might lead to unintended side effects. Consider using a new variable instead.
pref = url.href
Co-authored-by: Zoltan Kochan <z@kochan.io>
zkochan
approved these changes
Nov 18, 2024
|
Congrats on merging your first pull request! 🎉🎉🎉 |
zkochan
pushed a commit
that referenced
this pull request
Nov 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before determine the URL type, encode the hash if it contains a slash.
Fix: #7697