Skip to content

fix(cli): pnpm test requiring --#8491

Merged
zkochan merged 3 commits intov10from
forwarding-args-to-test-4821
Sep 4, 2024
Merged

fix(cli): pnpm test requiring --#8491
zkochan merged 3 commits intov10from
forwarding-args-to-test-4821

Conversation

@KSXGitHub
Copy link
Contributor

Fixes #4821

@KSXGitHub KSXGitHub requested a review from zkochan as a code owner September 3, 2024 06:48
@@ -0,0 +1,5 @@
---
"pnpm": patch
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zkochan This is probably major, but it's your decision.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@KSXGitHub KSXGitHub marked this pull request as draft September 3, 2024 11:18
@KSXGitHub KSXGitHub marked this pull request as ready for review September 4, 2024 16:19
@zkochan zkochan changed the base branch from main to v10 September 4, 2024 19:19
@zkochan zkochan merged commit 59d231e into v10 Sep 4, 2024
@zkochan zkochan deleted the forwarding-args-to-test-4821 branch September 4, 2024 19:20
@zkochan zkochan mentioned this pull request Sep 4, 2024
zkochan pushed a commit that referenced this pull request Sep 15, 2024
* fix(cli): `pnpm test` requiring `--`

Fixes #4821

* test: fix

* Update .changeset/short-ravens-clap.md
@zkochan zkochan added this to the v10.0 milestone Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Args forwarding with pnpm run test and pnpm test is inconsistent

2 participants