fix: wrong tag stated in pnpm publish#7862
Merged
Conversation
|
💖 Thanks for opening this pull request! 💖 |
zkochan
approved these changes
Apr 6, 2024
|
Congrats on merging your first pull request! 🎉🎉🎉 |
zkochan
added a commit
that referenced
this pull request
Apr 6, 2024
close #7845 --------- Co-authored-by: Zoltan Kochan <z@kochan.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #7845
Prior to this PR, pnpm publishes a package when we run
pnpm publish package-1.0.1.tgz --access public --no-git-checks --tag exp --ignore-scripts, but ignores--tag,--accessand all options.Because pnpm only passes the tarball name to params in releasing/plugin-commands-publishing/src/publish.ts.
After this PR we can use pnpm with any options.
I've just started learning about pnpm, so apologies if I'm wrong. The original code ignored processing for args, such as the
--publish-branchoption, because the processing for the tarball was done first, but I am not confident that this is correct.