refactor: bump lockfile version to v9 instead of v7#7861
Merged
Conversation
In order to align the lockfile version with pnpm version that ships it.
jakebailey
approved these changes
Apr 6, 2024
gluxon
approved these changes
Apr 6, 2024
This was referenced Apr 17, 2024
oliverchang
pushed a commit
to google/osv-scanner
that referenced
this pull request
Apr 30, 2024
This adds support for v9 PNPM lockfiles which has a different structure that looks to be similar to Yarn v2+ lockfiles. I can't find a lot of clear detail on the actual changes so I've started with just a "best effort" approach - most notably this means dev grouping is lost because that detail is not represented in the new format; we could probably successfully determine it by checking in `snapshots` but that would be a lot more work so I'm leaving that as a follow up. The good news is it seems like going forward the lockfile version should match the major verison of PNPM (pnpm/pnpm#7861) which should make it easier to track these, and we can probably drop explicit support for older versions in v2. Resolves #931
josieang
pushed a commit
to josieang/osv-scanner
that referenced
this pull request
Jun 6, 2024
This adds support for v9 PNPM lockfiles which has a different structure that looks to be similar to Yarn v2+ lockfiles. I can't find a lot of clear detail on the actual changes so I've started with just a "best effort" approach - most notably this means dev grouping is lost because that detail is not represented in the new format; we could probably successfully determine it by checking in `snapshots` but that would be a lot more work so I'm leaving that as a follow up. The good news is it seems like going forward the lockfile version should match the major verison of PNPM (pnpm/pnpm#7861) which should make it easier to track these, and we can probably drop explicit support for older versions in v2. Resolves google#931
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to align the lockfile version with pnpm version that ships it.