Update tslint to version 4.3.1 🚀#526
Closed
greenkeeperio-bot wants to merge 1 commit into
Closed
Conversation
pull Bot
pushed a commit
to dwongdev/pnpm
that referenced
this pull request
May 14, 2026
…npm#526) `create_symlink_layout` only iterated `snapshot.dependencies`, so a package whose CPU/OS-specific siblings live entirely under `optionalDependencies` (e.g. `@typescript/native-preview`, `@reflink/reflink`, every `*-darwin-arm64` / `*-linux-x64` family) ended up with a slot `node_modules/<scope>/` containing only the parent package — no platform binary sibling. Consumers that do `require.resolve('@typescript/native-preview-darwin-arm64')` from inside `getExePath.js` walked parent directories and found nothing, so `tsgo --version` (and every other tool that delegates to a platform variant) crashed with `Unable to resolve … missing the package on disk`. Port upstream's `dependencies ∪ optionalDependencies` merge — the graph builder at https://github.com/pnpm/pnpm/blob/da65e6262/deps/graph-builder/src/lockfileToDepGraph.ts#L150-L156 unifies both maps into one `allDeps` for each node's children, and `linkAllModules` then symlinks every child with two short-circuits: `alias === depNode.name` (a snapshot referencing itself) and `!pkg.installable && pkg.optional` (a non-materialized optional). See https://github.com/pnpm/pnpm/blob/da65e6262/installing/deps-installer/src/install/link.ts#L521-L549. `create_symlink_layout` now takes both maps and a `SkippedSnapshots` reference, merges them, and applies both short-circuits. The skip set is threaded through `InstallPackageBySnapshot` (cold batch) and the warm-batch `CreateVirtualDirBySnapshot` call site in `CreateVirtualStore::run`, so a target dropped by the installability pass, by `--no-optional`, or by a swallowed optional fetch failure gets no dangling symlink. Five new unit tests in `create_symlink_layout/tests.rs` cover the matching-optional happy path, the skipped-optional dangling-link guard, the self-name guard for entries listed in either bucket, the both-buckets-absent no-op, and the alias-resolve path (aliased deps still link the alias filename while resolving the slot via the target's name). End-to-end verification: `pacquet install --frozen-lockfile` followed by `tsgo --version` in the pnpm v11 repo now succeeds; the matching `native-preview-darwin-arm64` sibling shows up in the slot's `node_modules/@typescript/`. --- Written by an agent (Claude Code, claude-opus-4-7).
github-actions Bot
pushed a commit
to Eyalm321/pnpm
that referenced
this pull request
May 18, 2026
…npm#526) `create_symlink_layout` only iterated `snapshot.dependencies`, so a package whose CPU/OS-specific siblings live entirely under `optionalDependencies` (e.g. `@typescript/native-preview`, `@reflink/reflink`, every `*-darwin-arm64` / `*-linux-x64` family) ended up with a slot `node_modules/<scope>/` containing only the parent package — no platform binary sibling. Consumers that do `require.resolve('@typescript/native-preview-darwin-arm64')` from inside `getExePath.js` walked parent directories and found nothing, so `tsgo --version` (and every other tool that delegates to a platform variant) crashed with `Unable to resolve … missing the package on disk`. Port upstream's `dependencies ∪ optionalDependencies` merge — the graph builder at https://github.com/pnpm/pnpm/blob/da65e6262/deps/graph-builder/src/lockfileToDepGraph.ts#L150-L156 unifies both maps into one `allDeps` for each node's children, and `linkAllModules` then symlinks every child with two short-circuits: `alias === depNode.name` (a snapshot referencing itself) and `!pkg.installable && pkg.optional` (a non-materialized optional). See https://github.com/pnpm/pnpm/blob/da65e6262/installing/deps-installer/src/install/link.ts#L521-L549. `create_symlink_layout` now takes both maps and a `SkippedSnapshots` reference, merges them, and applies both short-circuits. The skip set is threaded through `InstallPackageBySnapshot` (cold batch) and the warm-batch `CreateVirtualDirBySnapshot` call site in `CreateVirtualStore::run`, so a target dropped by the installability pass, by `--no-optional`, or by a swallowed optional fetch failure gets no dangling symlink. Five new unit tests in `create_symlink_layout/tests.rs` cover the matching-optional happy path, the skipped-optional dangling-link guard, the self-name guard for entries listed in either bucket, the both-buckets-absent no-op, and the alias-resolve path (aliased deps still link the alias filename while resolving the slot via the target's name). End-to-end verification: `pacquet install --frozen-lockfile` followed by `tsgo --version` in the pnpm v11 repo now succeeds; the matching `native-preview-darwin-arm64` sibling shows up in the slot's `node_modules/@typescript/`. --- Written by an agent (Claude Code, claude-opus-4-7).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello lovely humans,
tslint just published its new version 4.3.1.
This version is not covered by your current version range.
Without accepting this pull request your project will work just like it did before. There might be a bunch of new features, fixes and perf improvements that the maintainers worked on for you though.
I recommend you look into these changes and try to get onto the latest version of tslint.
Given that you have a decent test suite, a passing build is a strong indicator that you can take advantage of these changes by merging the proposed change into your project. Otherwise this branch is a great starting point for you to work on the update.
Do you have any ideas how I could improve these pull requests? Did I report anything you think isn’t right?
Are you unsure about how things are supposed to work?
There is a collection of frequently asked questions and while I’m just a bot, there is a group of people who are happy to teach me new things. Let them know.
Good luck with your project ✨
You rock!
🌴
This pull request was created by greenkeeper.io.
Tired of seeing this sponsor message? ⚡
greenkeeper upgrade