Skip to content

Update npm-run-all to version 4.0.0 🚀#523

Closed
greenkeeperio-bot wants to merge 1 commit into
masterfrom
greenkeeper-npm-run-all-4.0.0
Closed

Update npm-run-all to version 4.0.0 🚀#523
greenkeeperio-bot wants to merge 1 commit into
masterfrom
greenkeeper-npm-run-all-4.0.0

Conversation

@greenkeeperio-bot

Copy link
Copy Markdown
Contributor

Hello lovely humans,

npm-run-all just published its new version 4.0.0.

State Update 🚀
Dependency npm-run-all
New version 4.0.0
Type devDependency

This version is not covered by your current version range.

Without accepting this pull request your project will work just like it did before. There might be a bunch of new features, fixes and perf improvements that the maintainers worked on for you though.

I recommend you look into these changes and try to get onto the latest version of npm-run-all.
Given that you have a decent test suite, a passing build is a strong indicator that you can take advantage of these changes by merging the proposed change into your project. Otherwise this branch is a great starting point for you to work on the update.

Do you have any ideas how I could improve these pull requests? Did I report anything you think isn’t right?
Are you unsure about how things are supposed to work?

There is a collection of frequently asked questions and while I’m just a bot, there is a group of people who are happy to teach me new things. Let them know.

Good luck with your project ✨

You rock!

🌴


The new version differs by 15 commits .

  • 5e88fb7 4.0.0
  • 12b2b87 Breaking: use NPM_EXECPATH to run tasks
  • 07bfec5 Chore: remove unused setting in .eslintrc.json
  • 02e9767 New: --max-parallel option
  • 58f9d4c Chore: remove read-pkg-up
  • 49528e4 Chore: update dependencies
  • 023a3c3 Fix: the leaks of modifications to remove babel
  • 26a951e Chore: upgrade nyc and mocha
  • c8c440d Chore: stop using babel
  • 993df33 Chore: remove polyfills
  • 3f933c3 Chore: upgrade eslint and eslint-config
  • 53d4f2a Breaking: drop supports for Node 0.x
  • fed85bf Chore: rename .eslintrc → .eslintrc.json
  • 910d78d Merge pull request #75 from nulltask/feature/colorize (fixes #73)
  • d7821df Change labels to be displayed in individual colors for each task

See the full diff.


This pull request was created by greenkeeper.io.

Tired of seeing this sponsor message? ⚡ greenkeeper upgrade

@rstacruz

rstacruz commented Jan 2, 2017

Copy link
Copy Markdown
Member

Unfortunately it drops support for node 0.12 (though it should really dropped since it's out of LTS range). Dropping support for 0.12 means having to upgrade more modules than this though.

@rstacruz rstacruz closed this Jan 2, 2017
@zkochan

zkochan commented Jan 2, 2017

Copy link
Copy Markdown
Member

But support for 0.12 was already dropped by pnpm@0.25 in the summer:
https://github.com/rstacruz/pnpm/blob/master/package.json#L127

@zkochan zkochan reopened this Jan 2, 2017
@zkochan zkochan closed this Jan 8, 2017
@zkochan zkochan deleted the greenkeeper-npm-run-all-4.0.0 branch January 8, 2017 13:59
pull Bot pushed a commit to dwongdev/pnpm that referenced this pull request May 14, 2026
…op-level bin re-link (#342) (pnpm#523)

Two related bin-linking behaviors deferred from #333.

Behavior 1 — hoisted-bin precedence:
- Add `BinOrigin { Direct, Hoisted }` discriminator to `PackageBinSource`.
- New top tier in `pick_winner`: Direct wins outright over Hoisted
  regardless of ownership / lexical order. Mirrors upstream's
  `preferDirectCmds` partition at
  https://github.com/pnpm/pnpm/blob/4750fd370c/bins/linker/src/index.ts#L92.
- New `link_top_level_bins(modules_dir, direct, hoisted)` helper in
  `pacquet-package-manager` mixes both candidate lists into one
  `link_bins_of_packages` call so the new tier resolves conflicts in
  a single pass — previously the two passes (SymlinkDirectDependencies
  for direct + hoist pass for publicly-hoisted) wrote shims
  independently and a hoisted bin could shadow a direct one when its
  package name was lexically smaller.

Behavior 2 — lifecycle-script-created bins:
- Add a post-`BuildModules` per-importer top-level bin link pass.
  Re-reading each direct dep's `package.json` after lifecycle
  scripts run picks up bins generated by `postinstall` (the
  `@pnpm.e2e/generated-bins` upstream fixture). Idempotent for
  unchanged shims via `is_shim_pointing_at`.
- Mirrors upstream's `linkBinsOfImporter` pass that runs after
  `buildModules` at
  https://github.com/pnpm/pnpm/blob/4750fd370c/installing/deps-installer/src/install/index.ts#L1539.

Supporting changes:
- `PackageBinSource::new(location, manifest)` constructor + `with_origin`
  builder so existing call sites don't have to spell out the new field.
- Public `direct_dep_names_for_importer` helper extracted from
  `SymlinkDirectDependencies` so the post-build pass uses the same
  filter (skipped / first-wins / link_only) as the symlink phase.
- `InstallFrozenLockfileError::TopLevelBinLink` for the new failure
  surface.

Tests:
- `direct_origin_wins_over_hoisted_regardless_of_lexical` — pins the
  new tier overrides lexical ordering.
- `hoisted_origin_loses_to_existing_direct` — pins both arms of the
  new tier (Direct incumbent vs Hoisted candidate).
github-actions Bot pushed a commit to Eyalm321/pnpm that referenced this pull request May 18, 2026
…op-level bin re-link (pnpm#342) (pnpm#523)

Two related bin-linking behaviors deferred from pnpm#333.

Behavior 1 — hoisted-bin precedence:
- Add `BinOrigin { Direct, Hoisted }` discriminator to `PackageBinSource`.
- New top tier in `pick_winner`: Direct wins outright over Hoisted
  regardless of ownership / lexical order. Mirrors upstream's
  `preferDirectCmds` partition at
  https://github.com/pnpm/pnpm/blob/4750fd370c/bins/linker/src/index.ts#L92.
- New `link_top_level_bins(modules_dir, direct, hoisted)` helper in
  `pacquet-package-manager` mixes both candidate lists into one
  `link_bins_of_packages` call so the new tier resolves conflicts in
  a single pass — previously the two passes (SymlinkDirectDependencies
  for direct + hoist pass for publicly-hoisted) wrote shims
  independently and a hoisted bin could shadow a direct one when its
  package name was lexically smaller.

Behavior 2 — lifecycle-script-created bins:
- Add a post-`BuildModules` per-importer top-level bin link pass.
  Re-reading each direct dep's `package.json` after lifecycle
  scripts run picks up bins generated by `postinstall` (the
  `@pnpm.e2e/generated-bins` upstream fixture). Idempotent for
  unchanged shims via `is_shim_pointing_at`.
- Mirrors upstream's `linkBinsOfImporter` pass that runs after
  `buildModules` at
  https://github.com/pnpm/pnpm/blob/4750fd370c/installing/deps-installer/src/install/index.ts#L1539.

Supporting changes:
- `PackageBinSource::new(location, manifest)` constructor + `with_origin`
  builder so existing call sites don't have to spell out the new field.
- Public `direct_dep_names_for_importer` helper extracted from
  `SymlinkDirectDependencies` so the post-build pass uses the same
  filter (skipped / first-wins / link_only) as the symlink phase.
- `InstallFrozenLockfileError::TopLevelBinLink` for the new failure
  surface.

Tests:
- `direct_origin_wins_over_hoisted_regardless_of_lexical` — pins the
  new tier overrides lexical ordering.
- `hoisted_origin_loses_to_existing_direct` — pins both arms of the
  new tier (Direct incumbent vs Hoisted candidate).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants