Update eslint to version 3.5.0 🚀#355
Closed
greenkeeperio-bot wants to merge 1 commit into
Closed
Conversation
pull Bot
pushed a commit
to dwongdev/pnpm
that referenced
this pull request
May 14, 2026
* feat(reporter): emit pnpm:summary at install end Adds the `Summary` variant to `LogEvent` and emits it from `Install::run` immediately after `pnpm:stage importing_done`. Mirrors pnpm's emit at https://github.com/pnpm/pnpm/blob/086c5e91e8/installing/deps-installer/src/install/index.ts#L1663. The payload carries only `prefix`; the reporter combines this with the accumulated `pnpm:root` events (still TODO under pnpm#347) to render the final "+N -M" diff block. Test: extends the install integration test (renamed to `install_emits_pnpm_event_sequence` to match the growing scope) to assert the four-event success sequence (`Context`, `ImportingStarted`, `ImportingDone`, `Summary`) and spot-checks summary's `prefix`. Verified the test catches the regression by temporarily commenting out the emit and confirming it failed with a Summary-shaped gap. Refs pnpm#347. Engine: pnpm#345. Previous channel: pnpm#354. * docs(reporter): clarify SummaryLog payload comment Per review feedback on pnpm#355: the original wording said the `pnpm:summary` payload "is just `prefix`", which omitted the `level` field that's also part of the serialized record. `level` is the bunyan-envelope severity carried by every channel, not channel-specific to summary; say so explicitly so a reader doesn't try to "fix" the struct based on the comment. Same fix applied to the wire-shape test's doc comment.
github-actions Bot
pushed a commit
to Eyalm321/pnpm
that referenced
this pull request
May 18, 2026
* feat(reporter): emit pnpm:summary at install end Adds the `Summary` variant to `LogEvent` and emits it from `Install::run` immediately after `pnpm:stage importing_done`. Mirrors pnpm's emit at https://github.com/pnpm/pnpm/blob/086c5e91e8/installing/deps-installer/src/install/index.ts#L1663. The payload carries only `prefix`; the reporter combines this with the accumulated `pnpm:root` events (still TODO under pnpm#347) to render the final "+N -M" diff block. Test: extends the install integration test (renamed to `install_emits_pnpm_event_sequence` to match the growing scope) to assert the four-event success sequence (`Context`, `ImportingStarted`, `ImportingDone`, `Summary`) and spot-checks summary's `prefix`. Verified the test catches the regression by temporarily commenting out the emit and confirming it failed with a Summary-shaped gap. Refs pnpm#347. Engine: pnpm#345. Previous channel: pnpm#354. * docs(reporter): clarify SummaryLog payload comment Per review feedback on pnpm#355: the original wording said the `pnpm:summary` payload "is just `prefix`", which omitted the `level` field that's also part of the serialized record. `level` is the bunyan-envelope severity carried by every channel, not channel-specific to summary; say so explicitly so a reader doesn't try to "fix" the struct based on the comment. Same fix applied to the wire-shape test's doc comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello lovely humans,
eslint just published its new version 3.5.0.
This version is not covered by your current version range.
Without accepting this pull request your project will work just like it did before. There might be a bunch of new features, fixes and perf improvements that the maintainers worked on for you though.
I recommend you look into these changes and try to get onto the latest version of eslint.
Given that you have a decent test suite, a passing build is a strong indicator that you can take advantage of these changes by merging the proposed change into your project. Otherwise this branch is a great starting point for you to work on the update.
Do you have any ideas how I could improve these pull requests? Did I report anything you think isn’t right?
Are you unsure about how things are supposed to work?
There is a collection of frequently asked questions and while I’m just a bot, there is a group of people who are happy to teach me new things. Let them know.
Good luck with your project ✨
You rock!
🌴
GitHub Release
arrow-spacing(fixes #7079) (#7080) (Toru Nagashima)max-len:ignoreStrings+ignoreTemplateLiterals(fixes #5805) (#7049) (Jordan Harband)comma-style(fixes #6941) (#6957) (Gyandeep Singh)no-consoleignores user-defined console (fixes #7010) (#7058) (Toru Nagashima)es6env also setsecmaVersionto 6 (#7067) (Jérémie Astori)indentoptions for functions (fixes #6052) (#7043) (not-an-aardvark)max-statements-per-linemessage (fixes #6287) (#7044) (Jordan Harband)prefer-numeric-literalsrule (fixes #6068) (#7029) (Annie Zhang)no-restricted-propertiesrule (fixes #3218) (#7017) (Eli White)new-parensfalse negative (fixes #6997) (#6999) (Toru Nagashima)line-comment-positionrule (fixes #6077) (#6953) (alberto)lines-around-directiverule (fixes #6069) (#6998) (Kai Cataldo)The new version differs by 41 commits .
18be52e3.5.08ff28c6Build: package.json and changelog update for 3.5.008fa538Update: fix false negative ofarrow-spacing(fixes #7079) (#7080)cec65e3Update: add fixer for no-floating-decimal (fixes #7070) (#7081)2a3f699Fix: Column number for no-multiple-empty-lines (fixes #7086) (#7088)6947299Docs: Add info about closing accepted issues to docs (fixes #6979) (#7089)d30157aDocs: Add link to awesome-eslint in integrations page (#7090)457be1bDocs: Update so issues are not required (fixes #7015) (#7072)d9513b7Fix: Allow linting of .hidden files/folders (fixes #4828) (#6844)6d97c18New:max-len:ignoreStrings+ignoreTemplateLiterals(fixes #5805) (#7049)538d258Update: make no-implicit-coercion support autofixing. (fixes #7056) (#7061)883316dUpdate: add fixer for prefer-arrow-callback (fixes #7002) (#7004)7502eedUpdate: auto-fix forcomma-style(fixes #6941) (#6957)645dda5Update: add fixer for dot-notation (fixes #7014) (#7054)2657846Fix:no-consoleignores user-defined console (fixes #7010) (#7058)There are 41 commits in total. See the full diff.
This pull request was created by greenkeeper.io.
Tired of seeing this sponsor message? ⚡
greenkeeper upgrade