Conversation
595e0c0 to
9981284
Compare
7eadc42 to
4644ddf
Compare
Member
Author
|
I am merging it because I have to create a new pull request based on these changes. But I'll be more then happy to make updates if someone will have comments. |
Contributor
|
Looks good |
Contributor
|
Just one question: why do we log only progress events? |
Member
Author
|
We don't log progress events. They are not useful. |
Member
Author
|
I mean the progress events that log download percentage |
Contributor
|
ok, got it. thanks |
KSXGitHub
pushed a commit
that referenced
this pull request
May 18, 2026
The "begrudging use behind pnpm/pacquet#343" phrasing reads as though #343 introduced the direct env reads in default_store_dir / default_modules_dir / default_virtual_store_dir. It did not — those helpers have read process state since they existed; #343 tracks retiring the env-mutating *tests* for them. The historical reference doesn't carry any rule the reader needs, so drop it and let the positive guidance stand on its own. https://claude.ai/code/session_01Btd6rp2MgfXb3ArHwSJpqA
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I created a custom logger for this feature (please review it as well @zkochan/logger). If it is fine, I'll transfer it to the pnpm organization.
The main idea is to use a logger which emits events with the logging info. The file logger records all the different logging levels. The progress logger listens only the
progresstype.Also I substituted the debug usages with @zkochan/logger usages. But I did not remove debug, it listens now for debug logging events.
Example output: https://gist.github.com/zkochan/272e4c60eb3248373c63af9bc2db8924