Skip to content

feat: --working-dir flag#2115

Merged
zkochan merged 4 commits intomasterfrom
feat/2088
Oct 27, 2019
Merged

feat: --working-dir flag#2115
zkochan merged 4 commits intomasterfrom
feat/2088

Conversation

@zkochan
Copy link
Copy Markdown
Member

@zkochan zkochan commented Oct 26, 2019

ref #2088

--prefix will continue to work for compatibility with npm but the docs will only mention --working-dir.

BREAKING CHANGE:

  • @pnpm/config
  • @pnpm/default-reporter
  • supi

@zkochan zkochan force-pushed the feat/2088 branch 3 times, most recently from e92a2ae to 0536331 Compare October 26, 2019 11:02
@zkochan zkochan requested a review from a team October 26, 2019 11:02
@zkochan zkochan added this to the v4.2 milestone Oct 26, 2019
@zkochan
Copy link
Copy Markdown
Member Author

zkochan commented Oct 26, 2019

Now that I know the origin of the -C flag, I am not sure what should be the flag's name. It can be just --dir instead of --working-dir.

@zkochan
Copy link
Copy Markdown
Member Author

zkochan commented Oct 27, 2019

I will rename the flag to --dir with a separate commit if it will win in the poll.

@zkochan zkochan merged commit 837b146 into master Oct 27, 2019
@zkochan zkochan deleted the feat/2088 branch October 27, 2019 00:08
zkochan added a commit that referenced this pull request Oct 27, 2019
54% of our users prefer the name --dir over --working-dir

https://twitter.com/pnpmjs/status/1188103282662748162

ref #2088
ref #2115
zkochan added a commit that referenced this pull request Oct 27, 2019
54% of our users prefer the name --dir over --working-dir

https://twitter.com/pnpmjs/status/1188103282662748162

PR #2122
close #2088
ref #2115
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant