Skip to content

print more consumer friendly error, when there is no ./package.json#155

Closed
iamstarkov wants to merge 1 commit into
pnpm:masterfrom
iamstarkov:fix/no-pkg
Closed

print more consumer friendly error, when there is no ./package.json#155
iamstarkov wants to merge 1 commit into
pnpm:masterfrom
iamstarkov:fix/no-pkg

Conversation

@iamstarkov

Copy link
Copy Markdown
Contributor

was not sure to exit with 0, while it still an error, 'cause then this error can be swallowed in someone CI build, which i personally want to avoid

@iamstarkov

Copy link
Copy Markdown
Contributor Author

is there any reason not to merge it?

@rstacruz

rstacruz commented Apr 2, 2016

Copy link
Copy Markdown
Member

sorry for the late reply! this looks like it breaks the workflow of running pnpm install lodash on any directory without package.json. the only thing that should be caught is when runnng pnpm install (without arguments).

@iamstarkov

Copy link
Copy Markdown
Contributor Author

okay, thats good

github-actions Bot pushed a commit to Eyalm321/pnpm that referenced this pull request May 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants