feat: link-workspace-packages#1331
Merged
Merged
Conversation
bce9254 to
70ada0a
Compare
70ada0a to
d928b3e
Compare
d928b3e to
724e817
Compare
zkochan
added a commit
that referenced
this pull request
May 24, 2026
…ay statuses Replaces the bespoke `reqwest::Client` builder in `Upstream` with `pacquet_network::ThrottledClient::new_for_installs()`, so the registry inherits pnpm's tuned defaults — `User-Agent: pnpm`, HTTP/1.1, hickory DNS, pool and timeout settings, the concurrency semaphore, and (later) per-registry TLS routing — instead of rolling its own and missing every one of them. Also splits the gateway error response by failure mode rather than falling back to a blanket `502` on every upstream failure: * `is_timeout()` → `504 Gateway Timeout` * `is_connect()` → `503 Service Unavailable` * anything else / upstream 5xx → `502 Bad Gateway` Mirrors verdaccio's role in the proxy: the npm client already has the configured `fetch-retries` policy, so the registry's job is to surface accurate gateway status so the client's retry loop fires on truly transient failures and gives up on permanent ones. No proxy-side retry — see verdaccio v4.0.3 / #1331 for the same reasoning.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref #1259