Skip to content

feat: link-workspace-packages#1331

Merged
zkochan merged 1 commit into
masterfrom
feat/link-workspace-packages
Aug 21, 2018
Merged

feat: link-workspace-packages#1331
zkochan merged 1 commit into
masterfrom
feat/link-workspace-packages

Conversation

@zkochan

@zkochan zkochan commented Aug 20, 2018

Copy link
Copy Markdown
Member

ref #1259

@zkochan zkochan force-pushed the feat/link-workspace-packages branch from bce9254 to 70ada0a Compare August 20, 2018 20:31
@zkochan zkochan force-pushed the feat/link-workspace-packages branch from 70ada0a to d928b3e Compare August 21, 2018 20:10
@zkochan zkochan force-pushed the feat/link-workspace-packages branch from d928b3e to 724e817 Compare August 21, 2018 20:13
@zkochan zkochan merged commit b093823 into master Aug 21, 2018
@zkochan zkochan deleted the feat/link-workspace-packages branch August 21, 2018 20:17
zkochan added a commit that referenced this pull request May 24, 2026
…ay statuses

Replaces the bespoke `reqwest::Client` builder in `Upstream` with
`pacquet_network::ThrottledClient::new_for_installs()`, so the
registry inherits pnpm's tuned defaults — `User-Agent: pnpm`,
HTTP/1.1, hickory DNS, pool and timeout settings, the concurrency
semaphore, and (later) per-registry TLS routing — instead of
rolling its own and missing every one of them.

Also splits the gateway error response by failure mode rather than
falling back to a blanket `502` on every upstream failure:

* `is_timeout()` → `504 Gateway Timeout`
* `is_connect()` → `503 Service Unavailable`
* anything else / upstream 5xx → `502 Bad Gateway`

Mirrors verdaccio's role in the proxy: the npm client already has
the configured `fetch-retries` policy, so the registry's job is to
surface accurate gateway status so the client's retry loop fires
on truly transient failures and gives up on permanent ones. No
proxy-side retry — see verdaccio v4.0.3 / #1331 for the same
reasoning.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant