ci(integrated-benchmark): double the precompile-revisions timeout by KSXGitHub · Pull Request #12713 · pnpm/pnpm

KSXGitHub · 2026-06-29T03:28:24Z

Note

This PR was cherry-picked from #12691.

Behind this PR is a human, not an AI agent.

Bump the "Precompile benchmark revisions" step from 25 to 50 minutes; the superset build of pacquet + pnpr revisions has been hitting the limit.

Summary

Squash Commit Body

PR <https://github.com/pnpm/pnpm/pull/12691> pull in additional dependencies to
support sigstore and provenance. This caused the build to take longer.

Checklist

The change is implemented in both the TypeScript CLI and the Rust
pacquet/ port, or the description notes what still needs porting. Irrelevant.
Added a changeset (pnpm changeset) if this PR changes any published
package. Keep it short and written for pnpm users — it becomes a release note. Irrelevant.
~~Added or updated tests.~~ Irrelevant.
~~Updated the documentation if needed.~~ Irrelevant.

Summary by CodeRabbit

Chores
- Increased the maximum build time for benchmark precompilation, reducing the chance of timeouts during longer benchmark runs.

Bump the "Precompile benchmark revisions" step from 25 to 50 minutes; the superset build of pacquet + pnpr revisions has been hitting the limit. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KtBQzmLLDU3RcGzzCMopPB

coderabbitai · 2026-06-29T03:28:31Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 2bc420f4-ed9a-4c39-a424-960d83451716

📥 Commits

Reviewing files that changed from the base of the PR and between 517ea5d and 66d0103.

📒 Files selected for processing (1)

.github/workflows/pacquet-integrated-benchmark.yml

📝 Walkthrough

Walkthrough

The timeout-minutes for the "Precompile benchmark revisions" step in .github/workflows/pacquet-integrated-benchmark.yml is increased from 25 to 50.

Changes

CI Benchmark Workflow

Layer / File(s)	Summary
Precompile step timeout `.github/workflows/pacquet-integrated-benchmark.yml`	`timeout-minutes` for the precompile benchmark revisions step changed from 25 to 50.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch ci-bump-integrated-benchmark-build-time

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

github-actions · 2026-06-29T04:08:48Z

Integrated-Benchmark Report (Linux)

Commit: 66d0103fe1c1

Each scenario reports direct installs and pnpr installs. Bencher consumes pacquet@HEAD and pnpr@HEAD.

Scenario: Isolated linker: fresh restore, cold cache + cold store

Command	Mean [s]	Min [s]	Max [s]	Relative
`pacquet@HEAD`	4.494 ± 0.109	4.368	4.711	1.53 ± 0.07
`pacquet@main`	4.464 ± 0.170	4.282	4.700	1.52 ± 0.08
`pnpr@HEAD`	2.943 ± 0.209	2.778	3.329	1.00 ± 0.08
`pnpr@main`	2.934 ± 0.114	2.825	3.143	1.00

BENCHMARK_REPORT.json

{
  "results": [
    {
      "command": "pacquet@HEAD",
      "mean": 4.49362761336,
      "stddev": 0.10892847588633658,
      "median": 4.4716045617599995,
      "user": 3.6854771399999997,
      "system": 3.3999515000000002,
      "min": 4.36848331026,
      "max": 4.71092890126,
      "times": [
        4.45610651526,
        4.48982978926,
        4.58402487626,
        4.71092890126,
        4.48710260826,
        4.41487333826,
        4.60880922726,
        4.39916544126,
        4.36848331026,
        4.41695212626
      ]
    },
    {
      "command": "pacquet@main",
      "mean": 4.46367154776,
      "stddev": 0.1701234115005357,
      "median": 4.40246093626,
      "user": 3.6737784399999995,
      "system": 3.3799619,
      "min": 4.28210167726,
      "max": 4.69992600026,
      "times": [
        4.58372640726,
        4.41367547326,
        4.69992600026,
        4.39124639926,
        4.30422134126,
        4.67382296526,
        4.65503067326,
        4.31675135326,
        4.31621318726,
        4.28210167726
      ]
    },
    {
      "command": "pnpr@HEAD",
      "mean": 2.94326756116,
      "stddev": 0.20926458904242098,
      "median": 2.83086324576,
      "user": 2.73952934,
      "system": 2.9835781999999997,
      "min": 2.77838560226,
      "max": 3.32943635626,
      "times": [
        3.32943635626,
        2.80723830626,
        2.86971376026,
        2.81006033826,
        2.82021172226,
        2.78720795826,
        3.20202674026,
        3.18688005826,
        2.84151476926,
        2.77838560226
      ]
    },
    {
      "command": "pnpr@main",
      "mean": 2.9339862028600003,
      "stddev": 0.11405416767539946,
      "median": 2.87305317626,
      "user": 2.7212469399999994,
      "system": 3.0070885,
      "min": 2.82473034126,
      "max": 3.14268828026,
      "times": [
        2.86043087926,
        3.14268828026,
        2.8503468872599997,
        3.0971581542599997,
        3.03453136126,
        2.87295442326,
        2.82473034126,
        2.86473994826,
        2.87315192926,
        2.91912982426
      ]
    }
  ]
}

Scenario: Isolated linker: fresh restore, hot cache + hot store

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`pacquet@HEAD`	643.4 ± 22.0	613.2	686.9	1.00
`pacquet@main`	669.3 ± 96.7	617.5	939.8	1.04 ± 0.15
`pnpr@HEAD`	691.6 ± 31.0	659.1	765.2	1.07 ± 0.06
`pnpr@main`	676.7 ± 14.6	646.9	691.1	1.05 ± 0.04

BENCHMARK_REPORT.json

{
  "results": [
    {
      "command": "pacquet@HEAD",
      "mean": 0.6434233257599999,
      "stddev": 0.022028373168172348,
      "median": 0.63749254446,
      "user": 0.38786349999999997,
      "system": 1.3193275999999998,
      "min": 0.61324577396,
      "max": 0.6869256929600001,
      "times": [
        0.6869256929600001,
        0.63536796596,
        0.65597271396,
        0.65624362896,
        0.6336541839600001,
        0.62114522796,
        0.61324577396,
        0.6396171229600001,
        0.62933414296,
        0.66272680396
      ]
    },
    {
      "command": "pacquet@main",
      "mean": 0.6693141023600001,
      "stddev": 0.09673393309900563,
      "median": 0.63729170246,
      "user": 0.39018769999999997,
      "system": 1.3359240000000001,
      "min": 0.61749757896,
      "max": 0.9398448129600001,
      "times": [
        0.61749757896,
        0.62339233096,
        0.65754616696,
        0.62007157696,
        0.6297550939600001,
        0.63402362396,
        0.66635686096,
        0.64055978096,
        0.9398448129600001,
        0.66409319696
      ]
    },
    {
      "command": "pnpr@HEAD",
      "mean": 0.69161966366,
      "stddev": 0.03100137857755447,
      "median": 0.6892893254600001,
      "user": 0.4007994999999999,
      "system": 1.3446764999999998,
      "min": 0.6591478029600001,
      "max": 0.76515214596,
      "times": [
        0.6661523999600001,
        0.69978925396,
        0.6866457809600001,
        0.69193286996,
        0.70016113096,
        0.6683313469600001,
        0.66915189296,
        0.76515214596,
        0.70973201196,
        0.6591478029600001
      ]
    },
    {
      "command": "pnpr@main",
      "mean": 0.67672548736,
      "stddev": 0.014577319306609979,
      "median": 0.6820290224600001,
      "user": 0.3824157999999999,
      "system": 1.3472278000000002,
      "min": 0.64693178196,
      "max": 0.69105628496,
      "times": [
        0.69105628496,
        0.68880769196,
        0.68515787496,
        0.64693178196,
        0.6809481149600001,
        0.6831099299600001,
        0.68858316996,
        0.65827904896,
        0.6754891859600001,
        0.66889178996
      ]
    }
  ]
}

Scenario: Isolated linker: fresh install, cold cache + cold store

Command	Mean [s]	Min [s]	Max [s]	Relative
`pacquet@HEAD`	4.682 ± 0.032	4.645	4.724	1.70 ± 0.03
`pacquet@main`	4.670 ± 0.037	4.611	4.735	1.70 ± 0.03
`pnpr@HEAD`	2.823 ± 0.108	2.689	3.011	1.03 ± 0.04
`pnpr@main`	2.749 ± 0.044	2.684	2.812	1.00

BENCHMARK_REPORT.json

{
  "results": [
    {
      "command": "pacquet@HEAD",
      "mean": 4.68176346016,
      "stddev": 0.03152970740388686,
      "median": 4.6784580792599995,
      "user": 3.8173765599999996,
      "system": 3.34445184,
      "min": 4.645189396759999,
      "max": 4.724313500759999,
      "times": [
        4.72152008776,
        4.72290375476,
        4.678801518759999,
        4.68687702076,
        4.648014390759999,
        4.65767222576,
        4.65422806576,
        4.645189396759999,
        4.6781146397599995,
        4.724313500759999
      ]
    },
    {
      "command": "pacquet@main",
      "mean": 4.669716633059999,
      "stddev": 0.0370015039431753,
      "median": 4.672047548759999,
      "user": 3.843378859999999,
      "system": 3.3150913399999995,
      "min": 4.61130373376,
      "max": 4.73510982076,
      "times": [
        4.69453115476,
        4.73510982076,
        4.685985500759999,
        4.63552416776,
        4.61130373376,
        4.656232525759999,
        4.663385205759999,
        4.680709891759999,
        4.700573288759999,
        4.6338110407599995
      ]
    },
    {
      "command": "pnpr@HEAD",
      "mean": 2.82342186246,
      "stddev": 0.10795556958793451,
      "median": 2.7896672232600004,
      "user": 2.5880969599999997,
      "system": 2.8812355399999996,
      "min": 2.68939036676,
      "max": 3.01075684176,
      "times": [
        2.86046200276,
        2.75216061276,
        3.01075684176,
        2.76327458076,
        2.68939036676,
        2.92931367776,
        2.70810662676,
        2.76675315576,
        2.94141946876,
        2.8125812907600003
      ]
    },
    {
      "command": "pnpr@main",
      "mean": 2.7493460036600004,
      "stddev": 0.04405512662575399,
      "median": 2.7574595217600004,
      "user": 2.5738503600000002,
      "system": 2.8987621399999997,
      "min": 2.68401210276,
      "max": 2.81238769776,
      "times": [
        2.7653081517599998,
        2.7535513757600003,
        2.76540455576,
        2.74788857376,
        2.81238769776,
        2.70668731076,
        2.76136766776,
        2.80641966676,
        2.68401210276,
        2.69043293376
      ]
    }
  ]
}

Scenario: Isolated linker: fresh install, hot cache + hot store

Command	Mean [s]	Min [s]	Max [s]	Relative
`pacquet@HEAD`	1.316 ± 0.011	1.294	1.331	2.02 ± 0.05
`pacquet@main`	1.353 ± 0.077	1.300	1.565	2.07 ± 0.13
`pnpr@HEAD`	0.653 ± 0.016	0.640	0.686	1.00
`pnpr@main`	0.710 ± 0.076	0.676	0.926	1.09 ± 0.12

BENCHMARK_REPORT.json

{
  "results": [
    {
      "command": "pacquet@HEAD",
      "mean": 1.31555491238,
      "stddev": 0.011207085072897052,
      "median": 1.31415471128,
      "user": 1.31641874,
      "system": 1.68184732,
      "min": 1.29366133378,
      "max": 1.33097249478,
      "times": [
        1.29366133378,
        1.33038210878,
        1.31816257978,
        1.32418096278,
        1.31628390578,
        1.31108780078,
        1.33097249478,
        1.30807307578,
        1.3120255167800001,
        1.31071934478
      ]
    },
    {
      "command": "pacquet@main",
      "mean": 1.35331631668,
      "stddev": 0.07710058271388524,
      "median": 1.33709846778,
      "user": 1.3100425400000002,
      "system": 1.7391577200000001,
      "min": 1.29970458478,
      "max": 1.56517702478,
      "times": [
        1.33217002978,
        1.35584282278,
        1.56517702478,
        1.34220988178,
        1.3533313067800001,
        1.33841678478,
        1.30818967178,
        1.33578015078,
        1.30234090878,
        1.29970458478
      ]
    },
    {
      "command": "pnpr@HEAD",
      "mean": 0.6525219748800001,
      "stddev": 0.01618895717340204,
      "median": 0.64684519678,
      "user": 0.34414054,
      "system": 1.26189282,
      "min": 0.63972427678,
      "max": 0.68635696278,
      "times": [
        0.64303212878,
        0.68635696278,
        0.64351698278,
        0.63972427678,
        0.6400271377800001,
        0.64990100778,
        0.67766631178,
        0.6503256377800001,
        0.65087991678,
        0.64378938578
      ]
    },
    {
      "command": "pnpr@main",
      "mean": 0.7103557613800001,
      "stddev": 0.07598830519615012,
      "median": 0.68911957628,
      "user": 0.3561946399999999,
      "system": 1.31352342,
      "min": 0.6762446227800001,
      "max": 0.9257466147800001,
      "times": [
        0.67849200178,
        0.6835135827800001,
        0.67945126278,
        0.6762446227800001,
        0.68954260578,
        0.68869654678,
        0.6957806457800001,
        0.69481209578,
        0.9257466147800001,
        0.69127763478
      ]
    }
  ]
}

Scenario: Isolated linker: fresh install, cold cache + hot store

Command	Mean [s]	Min [s]	Max [s]	Relative
`pacquet@HEAD`	2.962 ± 0.060	2.913	3.108	4.52 ± 0.12
`pacquet@main`	2.975 ± 0.033	2.921	3.013	4.54 ± 0.09
`pnpr@HEAD`	0.656 ± 0.010	0.640	0.674	1.00
`pnpr@main`	0.660 ± 0.010	0.643	0.673	1.01 ± 0.02

BENCHMARK_REPORT.json

{
  "results": [
    {
      "command": "pacquet@HEAD",
      "mean": 2.96153326498,
      "stddev": 0.05955398555702103,
      "median": 2.9413000564800003,
      "user": 1.76416018,
      "system": 1.9239771799999996,
      "min": 2.9126207009800003,
      "max": 3.10847539398,
      "times": [
        2.99494600398,
        2.9322555119800002,
        2.9126207009800003,
        2.94502328598,
        2.91609035998,
        2.92349152298,
        2.93757682698,
        2.94629205698,
        3.10847539398,
        2.99856098598
      ]
    },
    {
      "command": "pacquet@main",
      "mean": 2.9751156706799997,
      "stddev": 0.032598185525720094,
      "median": 2.9852186209800005,
      "user": 1.7491203799999997,
      "system": 1.98375408,
      "min": 2.92143107498,
      "max": 3.01342215498,
      "times": [
        3.00968458298,
        3.0013959309800002,
        2.9808477029800002,
        2.9895895389800002,
        2.95594817298,
        2.9920755909800003,
        2.92893922198,
        2.95782273498,
        3.01342215498,
        2.92143107498
      ]
    },
    {
      "command": "pnpr@HEAD",
      "mean": 0.65579883088,
      "stddev": 0.010256693092704666,
      "median": 0.6560490574800001,
      "user": 0.3463658799999999,
      "system": 1.26003248,
      "min": 0.6397190489800001,
      "max": 0.6744320769800001,
      "times": [
        0.6397190489800001,
        0.6550473539800001,
        0.65705076098,
        0.6574791599800001,
        0.6495475209800001,
        0.66264214198,
        0.6659205199800001,
        0.64430609398,
        0.6518436309800001,
        0.6744320769800001
      ]
    },
    {
      "command": "pnpr@main",
      "mean": 0.6600144517800001,
      "stddev": 0.01003908116031194,
      "median": 0.6625007644800001,
      "user": 0.35033598000000005,
      "system": 1.2814822799999999,
      "min": 0.6426011539800001,
      "max": 0.6733110969800001,
      "times": [
        0.6623198129800001,
        0.6426011539800001,
        0.6566584459800001,
        0.6471398289800001,
        0.6626817159800001,
        0.6643816589800001,
        0.6528885179800001,
        0.6703687289800001,
        0.6733110969800001,
        0.6677935569800001
      ]
    }
  ]
}

github-actions · 2026-06-29T04:08:50Z

Bencher Report

Branch	pr/12713
Testbed	pacquet

Click to view all benchmark results

Benchmark	Latency	Benchmark Result milliseconds (ms) (Result Δ%)	Upper Boundary milliseconds (ms) (Limit %)
isolated-linker.fresh-install.cold-cache.cold-store	📈 view plot 🚷 view threshold	4,681.76 ms (-1.49%) Baseline: 4,752.65 ms	5,703.18 ms (82.09%)
isolated-linker.fresh-install.cold-cache.hot-store	📈 view plot 🚷 view threshold	2,961.53 ms (-2.86%) Baseline: 3,048.69 ms	3,658.43 ms (80.95%)
isolated-linker.fresh-install.hot-cache.hot-store	📈 view plot 🚷 view threshold	1,315.55 ms (-3.06%) Baseline: 1,357.15 ms	1,628.58 ms (80.78%)
isolated-linker.fresh-restore.cold-cache.cold-store	📈 view plot 🚷 view threshold	4,493.63 ms (-7.06%) Baseline: 4,835.12 ms	5,802.15 ms (77.45%)
isolated-linker.fresh-restore.hot-cache.hot-store	📈 view plot 🚷 view threshold	643.42 ms (-0.81%) Baseline: 648.70 ms	778.44 ms (82.66%)

🐰 View full continuous benchmarking report in Bencher

github-actions · 2026-06-29T04:08:51Z

Bencher Report

Branch	pr/12713
Testbed	pnpr

⚠️ WARNING: No Threshold found!
Without a Threshold, no Alerts will ever be generated.
Latency (nanoseconds (ns))
Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds flag.

Click to view all benchmark results

Benchmark	Latency	milliseconds (ms)
isolated-linker.fresh-install.cold-cache.cold-store	📈 view plot ⚠️ NO THRESHOLD	2,823.42 ms
isolated-linker.fresh-install.cold-cache.hot-store	📈 view plot ⚠️ NO THRESHOLD	655.80 ms
isolated-linker.fresh-install.hot-cache.hot-store	📈 view plot ⚠️ NO THRESHOLD	652.52 ms
isolated-linker.fresh-restore.cold-cache.cold-store	📈 view plot ⚠️ NO THRESHOLD	2,943.27 ms
isolated-linker.fresh-restore.hot-cache.hot-store	📈 view plot ⚠️ NO THRESHOLD	691.62 ms

🐰 View full continuous benchmarking report in Bencher

Bring in the latest main: #12712 wires `--filter` selection into the recursive `run` / `exec` dispatch via the shared `select_recursive_projects` helper (the prerequisite for recursive publishing), and #12713 lands the same precompile-benchmark-revisions timeout bump already carried on this branch. Clean auto-merge, no conflicts. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KtBQzmLLDU3RcGzzCMopPB

KSXGitHub marked this pull request as ready for review June 29, 2026 03:28

KSXGitHub requested a review from zkochan as a code owner June 29, 2026 03:28

KSXGitHub changed the title ~~ci(benchmark): double the precompile-revisions timeout~~ ci(integrated-benchmark): double the precompile-revisions timeout Jun 29, 2026

KSXGitHub enabled auto-merge June 29, 2026 03:29

coderabbitai Bot approved these changes Jun 29, 2026

View reviewed changes

github-actions Bot added the reviewed: coderabbit CodeRabbit submitted an approving review label Jun 29, 2026

zkochan approved these changes Jun 29, 2026

View reviewed changes

KSXGitHub added this pull request to the merge queue Jun 29, 2026

github-actions Bot added the state: automerge label Jun 29, 2026

Merged via the queue into main with commit 4dabe4c Jun 29, 2026
28 checks passed

KSXGitHub deleted the ci-bump-integrated-benchmark-build-time branch June 29, 2026 06:25

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

ci(integrated-benchmark): double the precompile-revisions timeout#12713

ci(integrated-benchmark): double the precompile-revisions timeout#12713
KSXGitHub merged 1 commit into
mainfrom
ci-bump-integrated-benchmark-build-time

KSXGitHub commented Jun 29, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Jun 29, 2026 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Uh oh!

github-actions Bot commented Jun 29, 2026

Uh oh!

github-actions Bot commented Jun 29, 2026

Uh oh!

github-actions Bot commented Jun 29, 2026

⚠️ WARNING: No Threshold found!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Uh oh!

Conversation

KSXGitHub commented Jun 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Squash Commit Body

Checklist

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Jun 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Uh oh!

github-actions Bot commented Jun 29, 2026

Integrated-Benchmark Report (Linux)

Scenario: Isolated linker: fresh restore, cold cache + cold store

Scenario: Isolated linker: fresh restore, hot cache + hot store

Scenario: Isolated linker: fresh install, cold cache + cold store

Scenario: Isolated linker: fresh install, hot cache + hot store

Scenario: Isolated linker: fresh install, cold cache + hot store

Uh oh!

github-actions Bot commented Jun 29, 2026

Bencher Report

Uh oh!

github-actions Bot commented Jun 29, 2026

Bencher Report

⚠️ WARNING: No Threshold found!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

KSXGitHub commented Jun 29, 2026 •

edited

Loading

coderabbitai Bot commented Jun 29, 2026 •

edited

Loading