fix(ci): point pnpm CLI bencher extraction at pnpm11/pnpm by zkochan · Pull Request #12544 · pnpm/pnpm

zkochan · 2026-06-20T18:24:06Z

Summary

The full TS CI test job on main has been failing since #12537 (which relocated the TypeScript pnpm CLI from pnpm/ to pnpm11/pnpm/). The Extract pnpm CLI e2e test duration step still passed --package-dir pnpm to bencher-result-from-pnpm-summary.mjs. That path no longer exists, so the exec-summary lookup found no entry for it and the script exited 1, failing the job.

Example failure: https://github.com/pnpm/pnpm/actions/runs/27872725265/job/82487383311

This points --package-dir at the package's new location, pnpm11/pnpm.

Squash Commit Body

The TypeScript pnpm CLI was relocated from `pnpm/` to `pnpm11/pnpm/` in
pnpm/pnpm#12537, but the "Extract pnpm CLI e2e test duration" step still
passed `--package-dir pnpm`. That path no longer exists, so the
exec-summary lookup found no entry and the step exited 1, failing the
full TS CI test job on main.

Point `--package-dir` at the package's new location, `pnpm11/pnpm`.

Checklist

The change is implemented in both the TypeScript CLI and the Rust pacquet/ port, or the description notes what still needs porting. (CI-only change; no pacquet port needed.)
Added a changeset (pnpm changeset) if this PR changes any published package. (CI workflow only; no published package affected.)
Added or updated tests. (Not applicable — workflow path fix.)
Updated the documentation if needed. (Not applicable.)

Written by an agent (Claude Code, claude-opus-4-8).

Summary by CodeRabbit

Chores
- Updated internal test workflow configuration.

The TypeScript pnpm CLI was relocated from `pnpm/` to `pnpm11/pnpm/` in #12537, but the "Extract pnpm CLI e2e test duration" step still passed `--package-dir pnpm`. That path no longer exists, so the exec-summary lookup found no entry and the step exited 1, failing the full TS CI test job on main. Point `--package-dir` at the package's new location, `pnpm11/pnpm`.

coderabbitai · 2026-06-20T18:24:20Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 17280f87-138d-4447-995a-f4e7a79269e4

📥 Commits

Reviewing files that changed from the base of the PR and between f6dde62 and 536dd11.

📒 Files selected for processing (1)

.github/workflows/test.yml

📝 Walkthrough

Walkthrough

The CI workflow's "Extract pnpm CLI e2e test duration" step is updated to pass --package-dir pnpm11/pnpm instead of --package-dir pnpm when invoking bencher-result-from-pnpm-summary.mjs, reflecting a directory path change for the pnpm package.

Changes

CI Workflow Path Fix

Layer / File(s)	Summary
Update pnpm summary package-dir `.github/workflows/test.yml`	The `--package-dir` argument in the "Extract pnpm CLI e2e test duration" step is changed from `pnpm` to `pnpm11/pnpm`.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

pnpm/pnpm#12540: Updates the Rust pnpm_version_from manifest path from pnpm/... to pnpm11/pnpm/..., reflecting the same package directory restructuring that this PR accounts for in the CI test extraction step.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch fix/bencher-pnpm-cli-package-dir

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

qodo-free-for-open-source-projects · 2026-06-20T18:24:45Z

PR Summary by Qodo

fix(ci): update Bencher pnpm CLI package-dir to pnpm11/pnpm
🐞 Bug fix ⚙️ Configuration changes 🕐 Less than 5 minutes

Description

• Fix failing TS CI Bencher extraction by pointing to the relocated pnpm CLI package directory.
• Update the workflow step to use pnpm11/pnpm so exec-summary lookup succeeds.

Diagram

graph TD
  A["GitHub Actions: test.yml"] --> B["Step: Extract CLI duration"] --> C["bencher-result-from-pnpm-summary.mjs"] --> D["--package-dir pnpm11/pnpm"] --> E[".bench/tests.cli.json"]

High-Level Assessment

The following are alternative approaches to this PR:

1. Auto-detect pnpm CLI package path

➕ Reduces future CI breakage when package directories move again
➕ Avoids hardcoding a path in the workflow
➖ Requires additional scripting/logic (and potentially repo-structure assumptions)
➖ Higher change surface area for a simple CI fix

2. Allow fallback package-dir values in the script

➕ Makes the extraction more resilient (try pnpm/, then pnpm11/pnpm/)
➕ Keeps workflow simpler and centralizes logic in one place
➖ Adds complexity to the extraction script and can mask unexpected repo layout changes
➖ Still requires periodic updates when layouts diverge further

Recommendation: The current approach (updating the workflow to the correct new path) is the best immediate fix because it’s low-risk and directly addresses the failure. If this path is expected to change again, consider a follow-up to auto-detect or add a controlled fallback in the extraction script to reduce brittleness.

Files changed (1) +1 / -1

Other (1) +1 / -1

test.ymlFix Bencher extraction package-dir after pnpm CLI relocation +1/-1

Fix Bencher extraction package-dir after pnpm CLI relocation

• Updates the Bencher extraction step to pass the new pnpm CLI package location ('pnpm11/pnpm') instead of the old 'pnpm' directory. This prevents the exec-summary lookup from missing the entry and failing the CI job.

.github/workflows/test.yml

qodo-free-for-open-source-projects · 2026-06-20T18:25:19Z

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Auto-approved notes
- no code review findings
- 'auto_approve_for_no_suggestions' flag enabled

Previous review results

Review updated until commit 536dd11

Results up to commit 536dd11

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Auto-approved notes
- no code review findings
- 'auto_approve_for_no_suggestions' flag enabled

qodo-free-for-open-source-projects · 2026-06-20T18:27:09Z

Code review by qodo was updated up to the latest commit 536dd11

qodo-free-for-open-source-projects Bot approved these changes Jun 20, 2026

View reviewed changes

github-actions Bot added the reviewed: qodo label Jun 20, 2026

coderabbitai Bot approved these changes Jun 20, 2026

View reviewed changes

github-actions Bot added the reviewed: coderabbit CodeRabbit submitted an approving review label Jun 20, 2026

qodo-free-for-open-source-projects Bot approved these changes Jun 20, 2026

View reviewed changes

zkochan merged commit 258b112 into main Jun 20, 2026
27 checks passed

zkochan deleted the fix/bencher-pnpm-cli-package-dir branch June 20, 2026 18:34

This was referenced Jun 23, 2026

ci: shard Windows TS tests #12612

Merged

ci: fix release workflow body generation #12614

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix(ci): point pnpm CLI bencher extraction at pnpm11/pnpm#12544

fix(ci): point pnpm CLI bencher extraction at pnpm11/pnpm#12544
zkochan merged 1 commit into
mainfrom
fix/bencher-pnpm-cli-package-dir

zkochan commented Jun 20, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Jun 20, 2026 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Uh oh!

qodo-free-for-open-source-projects Bot commented Jun 20, 2026

Uh oh!

qodo-free-for-open-source-projects Bot commented Jun 20, 2026 •

edited

Loading

Great, no issues found!

Uh oh!

qodo-free-for-open-source-projects Bot commented Jun 20, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Uh oh!

Conversation

zkochan commented Jun 20, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Squash Commit Body

Checklist

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Jun 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Uh oh!

qodo-free-for-open-source-projects Bot commented Jun 20, 2026

PR Summary by Qodo

Uh oh!

qodo-free-for-open-source-projects Bot commented Jun 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review by Qodo

Great, no issues found!

Previous review results

Great, no issues found!

Uh oh!

qodo-free-for-open-source-projects Bot commented Jun 20, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

zkochan commented Jun 20, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Jun 20, 2026 •

edited

Loading

qodo-free-for-open-source-projects Bot commented Jun 20, 2026 •

edited

Loading