fix(pacquet): read moved pnpm sources from their pnpm11/ locations#12540
Conversation
#12537 moved the TypeScript pnpm CLI under `pnpm11/`, so `pnpm_version_from` could no longer find `pnpm/package.json`; `current_source_pnpm_version` then returned `None` and `package_manager_to_sync` (and its test) failed. Written by an agent (Claude Code, claude-opus-4-8).
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughTwo single-line changes align paths to pnpm11: Changespnpm11 path alignment
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
PR Summary by QodoFix pnpm CLI version lookup for pnpm11 directory layout Description
Diagram
High-Level Assessment
Files changed (1)
|
Code Review by Qodo
1. Missing legacy pnpm path
|
|
Code review by qodo was updated up to the latest commit 21d0c4f |
Micro-Benchmark ResultsLinux |
The `pnpm_default_parity` contract tests read pnpm's `defaultOptions` from `config/reader/src/index.ts` in the TypeScript tree, which moved under `pnpm11/` in #12537. Point the path at the new location so the tests stop failing with a missing-file panic. Written by an agent (Claude Code, claude-opus-4-8).
|
Code review by qodo was updated up to the latest commit 35c4eb0 |
1 similar comment
|
Code review by qodo was updated up to the latest commit 35c4eb0 |
Summary
#12537 moved the TypeScript pnpm CLI into a
pnpm11/directory, but two pacquet code paths still read the old top-level locations, so they fail onmain:pacquet-cli'spnpm_version_fromreadpnpm/package.json(nowpnpm11/pnpm/package.json), socurrent_source_pnpm_version()returnedNoneandpackage_manager_to_sync_preserves_dev_engine_specifierfailed.pacquet-config'spnpm_default_paritycontract tests readconfig/reader/src/index.ts(nowpnpm11/config/reader/src/index.ts), so both parity tests failed with a missing-file panic.Point both at their new
pnpm11/locations.Squash Commit Body
Checklist
pacquet/port, or the description notes what still needs porting.Written by an agent (Claude Code, claude-opus-4-8).
Summary by CodeRabbit