fix(pacquet/config): satisfy dylint perfectionist lints#11672
Merged
Conversation
Two pre-existing perfectionist findings landed via #11526 and broke the Dylint CI job on main: - `perfectionist::macro-trailing-comma` flagged a trailing comma in a single-line `assert_eq!(...)` that `cargo fmt` had collapsed from a multi-line form without dropping the comma. Removed the comma. - `perfectionist::unicode_ellipsis_in_comments` warned about a U+2026 `…` character in a test comment. CI runs with `RUSTFLAGS=-D warnings`, so the warning fails the build. Replaced with ASCII `...`. Verified locally with `cargo dylint --all -- --all-targets --workspace` under `RUSTFLAGS=-D warnings`; passes clean. --- Written by an agent (Claude Code, claude-opus-4-7).
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📜 Recent review details⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (11)
🧰 Additional context used📓 Path-based instructions (1)pacquet/**/*.rs📄 CodeRabbit inference engine (pacquet/AGENTS.md)
Files:
🔇 Additional comments (2)
📝 WalkthroughWalkthroughTwo test files in the config crate receive cosmetic improvements: a trailing comma is removed from an assertion in ChangesTest Code Formatting Fixes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #11672 +/- ##
==========================================
- Coverage 89.12% 89.12% -0.01%
==========================================
Files 127 127
Lines 14470 14470
==========================================
- Hits 12897 12896 -1
- Misses 1573 1574 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Micro-Benchmark ResultsLinux |
Contributor
Integrated-Benchmark Report (Linux)Scenario: Frozen Lockfile
BENCHMARK_REPORT.json{
"results": [
{
"command": "pacquet@HEAD",
"mean": 2.5218007002999996,
"stddev": 0.08048458994004838,
"median": 2.5107317428,
"user": 2.65282628,
"system": 3.80478646,
"min": 2.3968470438,
"max": 2.6792207038,
"times": [
2.6792207038,
2.4744011198,
2.3968470438,
2.5945165238,
2.5798175268,
2.4799992178,
2.5011873427999998,
2.5376190818,
2.5202761428,
2.4541222998
]
},
{
"command": "pacquet@main",
"mean": 2.5428405004999997,
"stddev": 0.07276099563299888,
"median": 2.5439759982999997,
"user": 2.66322748,
"system": 3.81561296,
"min": 2.3783311497999997,
"max": 2.6215491807999998,
"times": [
2.5177548688,
2.5912833408,
2.5404486278,
2.6057144867999997,
2.6036740768,
2.3783311497999997,
2.5464685998,
2.5414833968,
2.4816972768,
2.6215491807999998
]
},
{
"command": "pnpm",
"mean": 4.8841880367,
"stddev": 0.07386265077030833,
"median": 4.8609530563000005,
"user": 8.33506648,
"system": 4.1570728599999995,
"min": 4.7777812898,
"max": 5.038201545800001,
"times": [
5.038201545800001,
4.8508719258,
4.863881681800001,
4.8540080668000005,
4.929538706800001,
4.8755278308,
4.9621371938,
4.8580244308000005,
4.8319076948,
4.7777812898
]
}
]
}Scenario: Frozen Lockfile (Hot Cache)
BENCHMARK_REPORT.json{
"results": [
{
"command": "pacquet@HEAD",
"mean": 0.7096376627200002,
"stddev": 0.0319685478184504,
"median": 0.6986464853200001,
"user": 0.37415040000000005,
"system": 1.6075652200000001,
"min": 0.6838100503200001,
"max": 0.7940659753200001,
"times": [
0.7940659753200001,
0.7181021133200001,
0.6895228253200001,
0.6838100503200001,
0.6977144283200001,
0.69203278032,
0.6938637453200001,
0.7071735853200001,
0.69957854232,
0.7205125813200001
]
},
{
"command": "pacquet@main",
"mean": 0.8107224655200002,
"stddev": 0.0742106506174786,
"median": 0.78479027032,
"user": 0.3752257,
"system": 1.6327486199999999,
"min": 0.7390579893200001,
"max": 0.9473157643200001,
"times": [
0.9416297573200001,
0.7773934103200001,
0.76480541032,
0.7544936603200001,
0.9473157643200001,
0.7390579893200001,
0.7921871303200001,
0.7678874493200001,
0.8173488733200001,
0.80510521032
]
},
{
"command": "pnpm",
"mean": 2.5653762981199995,
"stddev": 0.1478990873379593,
"median": 2.5083443893199995,
"user": 3.2144634000000005,
"system": 2.18858532,
"min": 2.4056151623199997,
"max": 2.89753138632,
"times": [
2.89753138632,
2.74048660732,
2.4927845713199996,
2.55020463332,
2.4607747403199998,
2.5239042073199998,
2.4056151623199997,
2.49060754332,
2.5999869683199996,
2.49186716132
]
}
]
} |
github-actions Bot
pushed a commit
to Eyalm321/pnpm
that referenced
this pull request
May 18, 2026
Two pre-existing perfectionist findings landed via pnpm#11526 and broke the Dylint CI job on main: - `perfectionist::macro-trailing-comma` flagged a trailing comma in a single-line `assert_eq!(...)` that `cargo fmt` had collapsed from a multi-line form without dropping the comma. Removed the comma. - `perfectionist::unicode_ellipsis_in_comments` warned about a U+2026 `…` character in a test comment. CI runs with `RUSTFLAGS=-D warnings`, so the warning fails the build. Replaced with ASCII `...`. Verified locally with `cargo dylint --all -- --all-targets --workspace` under `RUSTFLAGS=-D warnings`; passes clean. --- Written by an agent (Claude Code, claude-opus-4-7).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#11526 landed two changes that trip the perfectionist Dylint lints under CI's
RUSTFLAGS=-D warnings:perfectionist::macro-trailing-comma—cargo fmtcollapsed a multi-lineassert_eq!(...)into a single line inpacquet/crates/config/src/env_replace.rs:322but kept the trailing comma. Removed the trailing comma.perfectionist::unicode_ellipsis_in_comments— a U+2026…in a test comment inpacquet/crates/config/src/npmrc_auth/tests.rs:146. Replaced with ASCII....Verified locally with
cargo dylint --all -- --all-targets --workspaceunderRUSTFLAGS=-D warnings; passes clean.cargo fmt --check+cargo nextest run -p pacquet-configalso clean.Restores green Dylint on main: https://github.com/pnpm/pnpm/actions/runs/25923143087/job/76197188840
Test plan
RUSTFLAGS=-D warnings cargo dylint --all -- --all-targets --workspace— cleancargo fmt --check -p pacquet-config— cleancargo nextest run -p pacquet-config— all 154 tests passWritten by an agent (Claude Code, claude-opus-4-7).
Summary by CodeRabbit