ci: run install with pacquet by zkochan · Pull Request #11657 · pnpm/pnpm

zkochan · 2026-05-14T21:33:00Z

Summary by CodeRabbit

Chores
- Updated CI/CD workflow configurations to improve dependency installation efficiency and build processes.

coderabbitai · 2026-05-14T21:33:06Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: e0a6b345-91eb-4847-af26-33e11a37830b

📥 Commits

Reviewing files that changed from the base of the PR and between ae703b1 and 6db8cf1.

📒 Files selected for processing (2)

.github/workflows/ci.yml
.github/workflows/test.yml

📜 Recent review details

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

GitHub Check: Agent

🔇 Additional comments (2)

.github/workflows/ci.yml (1)

18-20: LGTM!

Also applies to: 28-31

.github/workflows/test.yml (1)

32-34: LGTM!

Also applies to: 52-55

📝 Walkthrough

Walkthrough

This PR updates the CI and test workflows to use pacquet as an explicit package installer with frozen-lockfile enforcement. Both workflows disable pnpm's built-in dependency verification and replace implicit pnpm setup-based installation with explicit pacquet install steps.

Changes

Pacquet installer integration in CI/test workflows

Layer / File(s)	Summary
Compile-and-lint workflow: Pacquet installation `.github/workflows/ci.yml`	Job-level env disables pnpm dependency verification; pnpm setup skips auto-install; new pacquet step runs with frozen-lockfile before TypeScript and lint checks.
Test workflow: Pacquet installation `.github/workflows/test.yml`	Job-level env disables pnpm dependency verification; pnpm setup skips auto-install; new pacquet step runs with frozen-lockfile and no-runtime flag before tests.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

pnpm/pnpm#11589: Workflow setup migration involving pnpm/setup configuration and dependency installation behavior.

Poem

🐰 A pacquet hops in with frozen lockfile grace,
No verification delays this CI race,
Both workflows aligned in their install way,
Dependencies locked—hooray, hooray! 🎯

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'ci: run install with pacquet' clearly and concisely describes the main change: updating CI workflows to use pacquet for dependency installation instead of the default approach.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch ci-pacquet-install

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

Generate code and open pull requests
Plan features and break down work
Investigate incidents and troubleshoot customer tickets together
Automate recurring tasks and respond to alerts with triggers
Summarize progress and report instantly

Built for teams:

Shared memory across your entire org—no repeating context
Per-thread sandboxes to safely plan and execute work
Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai · 2026-05-14T21:37:44Z

Caution

Failed to replace (edit) comment. This is likely due to insufficient permissions or the comment being deleted.

Error details

{"name":"HttpError","status":500,"request":{"method":"PATCH","url":"https://api.github.com/repos/pnpm/pnpm/issues/comments/4454912137","headers":{"accept":"application/vnd.github.v3+json","user-agent":"octokit.js/0.0.0-development octokit-core.js/7.0.6 Node.js/24","authorization":"token [REDACTED]","content-type":"application/json; charset=utf-8"},"body":{"body":"<!-- This is an auto-generated comment: summarize by coderabbit.ai -->\n<!-- This is an auto-generated comment: skip review by coderabbit.ai -->\n\n> [!IMPORTANT]\n> ## Review skipped\n> \n> Draft detected.\n> \n> Please check the settings in the CodeRabbit UI or the `.coderabbit.yaml` file in this repository. To trigger a single review, invoke the `@coderabbitai review` command.\n> \n> <details>\n> <summary>⚙️ Run configuration</summary>\n> \n> **Configuration used**: Organization UI\n> \n> **Review profile**: CHILL\n> \n> **Plan**: Pro Plus\n> \n> **Run ID**: `7646f83f-493b-4d32-881c-6a42b4221dba`\n> \n> </details>\n> \n> You can disable this status message by setting the `reviews.review_status` to `false` in the CodeRabbit configuration file.\n> \n> Use the checkbox below for a quick retry:\n> - [ ] <!-- {\"checkboxId\": \"e9bb8d72-00e8-4f67-9cb2-caf3b22574fe\"} --> 🔍 Trigger review\n\n<!-- end of auto-generated comment: skip review by coderabbit.ai -->\n\n<!-- finishing_touch_checkbox_start -->\n\n<details>\n<summary>✨ Finishing Touches</summary>\n\n<details>\n<summary>🧪 Generate unit tests (beta)</summary>\n\n- [ ] <!-- {\"checkboxId\": \"f47ac10b-58cc-4372-a567-0e02b2c3d479\", \"radioGroupId\": \"utg-output-choice-group-unknown_comment_id\"} -->   Create PR with unit tests\n- [ ] <!-- {\"checkboxId\": \"6ba7b810-9dad-11d1-80b4-00c04fd430c8\", \"radioGroupId\": \"utg-output-choice-group-unknown_comment_id\"} -->   Commit unit tests in branch `ci-pacquet-install`\n\n</details>\n\n</details>\n\n<!-- finishing_touch_checkbox_end -->\n<!-- tips_start -->\n\n---\n\n\n\n\n<sub>Comment `@coderabbitai help` to get the list of available commands and usage tips.</sub>\n\n<!-- tips_end -->"},"request":{"retryCount":3,"signal":{},"retries":3,"retryAfter":16}}}

github-actions · 2026-05-14T22:05:41Z

Integrated-Benchmark Report (Linux)

Scenario: Frozen Lockfile

Command	Mean [s]	Min [s]	Max [s]	Relative
`pacquet@HEAD`	2.532 ± 0.122	2.405	2.720	1.02 ± 0.06
`pacquet@main`	2.487 ± 0.075	2.377	2.609	1.00
`pnpm`	4.712 ± 0.099	4.611	4.975	1.89 ± 0.07

BENCHMARK_REPORT.json

{
  "results": [
    {
      "command": "pacquet@HEAD",
      "mean": 2.5323674072199998,
      "stddev": 0.12152399899432913,
      "median": 2.4859087958200003,
      "user": 2.7532099200000006,
      "system": 3.814021699999999,
      "min": 2.40452113982,
      "max": 2.7196495078200003,
      "times": [
        2.68243335782,
        2.4493682148200002,
        2.48255908082,
        2.44122733382,
        2.43385469882,
        2.70409156282,
        2.7196495078200003,
        2.48925851082,
        2.51671066482,
        2.40452113982
      ]
    },
    {
      "command": "pacquet@main",
      "mean": 2.4871808084199993,
      "stddev": 0.07508470420478619,
      "median": 2.47799164032,
      "user": 2.73391132,
      "system": 3.7840637,
      "min": 2.37695199182,
      "max": 2.60860902382,
      "times": [
        2.5855552308200003,
        2.40076122482,
        2.60860902382,
        2.37695199182,
        2.51411452582,
        2.47139448082,
        2.48458879982,
        2.53253444982,
        2.43006608482,
        2.46723227182
      ]
    },
    {
      "command": "pnpm",
      "mean": 4.7116588231200005,
      "stddev": 0.09946345138784234,
      "median": 4.696814484820001,
      "user": 8.01798942,
      "system": 4.1470788999999995,
      "min": 4.61072938682,
      "max": 4.9752431798200005,
      "times": [
        4.69067992182,
        4.71981538282,
        4.9752431798200005,
        4.69669702882,
        4.622853285820001,
        4.69741539682,
        4.696931940820001,
        4.693350666820001,
        4.61072938682,
        4.712872040820001
      ]
    }
  ]
}

Scenario: Frozen Lockfile (Hot Cache)

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
`pacquet@HEAD`	785.5 ± 63.6	714.7	927.0	1.00
`pacquet@main`	801.5 ± 51.6	741.8	902.1	1.02 ± 0.11
`pnpm`	2501.2 ± 104.0	2371.0	2627.0	3.18 ± 0.29

BENCHMARK_REPORT.json

{
  "results": [
    {
      "command": "pacquet@HEAD",
      "mean": 0.78553858956,
      "stddev": 0.06364697322315264,
      "median": 0.7586714235600001,
      "user": 0.38919377999999993,
      "system": 1.6531743199999998,
      "min": 0.71469047056,
      "max": 0.92703690656,
      "times": [
        0.92703690656,
        0.8345836815600001,
        0.7458639545600001,
        0.73262582856,
        0.71469047056,
        0.7539016915600001,
        0.82589249456,
        0.76344115556,
        0.7519718795600001,
        0.8053778325600001
      ]
    },
    {
      "command": "pacquet@main",
      "mean": 0.8014989748600001,
      "stddev": 0.05160056726433337,
      "median": 0.7823831345600001,
      "user": 0.40286957999999995,
      "system": 1.67216992,
      "min": 0.7417833405600001,
      "max": 0.9021175395600001,
      "times": [
        0.9021175395600001,
        0.75701945656,
        0.7796840075600001,
        0.8149426405600001,
        0.78508226156,
        0.86876021956,
        0.76732403756,
        0.7417833405600001,
        0.7702780745600001,
        0.82799817056
      ]
    },
    {
      "command": "pnpm",
      "mean": 2.50122716116,
      "stddev": 0.10398540262257253,
      "median": 2.4713920095599997,
      "user": 3.11198608,
      "system": 2.2450558199999997,
      "min": 2.37098294156,
      "max": 2.62702045956,
      "times": [
        2.38796800556,
        2.44814994456,
        2.6260391895599997,
        2.62702045956,
        2.37098294156,
        2.60052047356,
        2.49463407456,
        2.40701818456,
        2.4431126865599997,
        2.60682565156
      ]
    }
  ]
}

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

zkochan added 6 commits May 15, 2026 02:33

ci: don't verify deps before run

2844302

ci: run install with pacquet

f066288

ci: fix workflow

d3700fc

ci: disable verify before run

3a8c01b

Merge branch 'node-runtime-fix' into ci-pacquet-install

abdbb89

revert: change in pnpm-workspace.yaml

59c1411

zkochan force-pushed the ci-pacquet-install branch from b0aad4d to 59c1411 Compare May 15, 2026 00:34

zkochan added 2 commits May 15, 2026 07:02

ci: hoist verify-deps env to job level

ad6deaa

ci: fix runtime install

6db8cf1

zkochan marked this pull request as ready for review May 15, 2026 06:06

Copilot AI review requested due to automatic review settings May 15, 2026 06:06

Copilot started reviewing on behalf of zkochan May 15, 2026 06:06 View session

coderabbitai Bot approved these changes May 15, 2026

View reviewed changes

Copilot AI reviewed May 15, 2026

zkochan merged commit 7ff112b into main May 15, 2026
18 of 19 checks passed

zkochan deleted the ci-pacquet-install branch May 15, 2026 06:10

zkochan mentioned this pull request May 15, 2026

feat(package-manager): write .pnpm-workspace-state-v1.json after install #11665

Merged

6 tasks

github-actions Bot pushed a commit to Eyalm321/pnpm that referenced this pull request May 18, 2026

ci: run install with pacquet (pnpm#11657)

bc096f4

coderabbitai Bot mentioned this pull request May 29, 2026

chore: only run expensive Rust pre-push checks when pacquet or registry change #12050

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

ci: run install with pacquet#11657

ci: run install with pacquet#11657
zkochan merged 8 commits into
mainfrom
ci-pacquet-install

zkochan commented May 14, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented May 14, 2026 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Poem

Uh oh!

coderabbitai Bot commented May 14, 2026

Uh oh!

github-actions Bot commented May 14, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

zkochan commented May 14, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented May 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Poem

Uh oh!

coderabbitai Bot commented May 14, 2026

Uh oh!

github-actions Bot commented May 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Integrated-Benchmark Report (Linux)

Scenario: Frozen Lockfile

Scenario: Frozen Lockfile (Hot Cache)

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

zkochan commented May 14, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented May 14, 2026 •

edited

Loading

github-actions Bot commented May 14, 2026 •

edited

Loading