feat(config.reader): export getNetworkConfigs and getDefaultCreds by zkochan · Pull Request #11471 · pnpm/pnpm

zkochan · 2026-05-05T15:01:02Z

Summary

Re-export getNetworkConfigs, getDefaultCreds, and the NetworkConfigs type from @pnpm/config.reader.
Both helpers already exist in getNetworkConfigs.ts and are used internally by getConfig to build pnpmConfig.configByUri. They're shipped to lib/ but blocked from deep imports by the package's exports field.

Motivation

Downstream consumers of @pnpm/installing.client and @pnpm/store.connection-manager need to provide a configByUri: Record<string, RegistryConfig> argument. The only way to derive that map from a flat npmrc-style auth dict (the shape returned by, e.g., bit's getAuthConfig) is to re-implement pnpm's parsing logic, which keeps drifting out of sync with the canonical implementation. Exporting the existing helpers lets consumers stay aligned with pnpm's behaviour for free.

Test plan

pnpm --filter @pnpm/config.reader run compile — passes (lint warning is pre-existing).
Bit imports the new exports and drops its local copy (separate PR; gated on a published @pnpm/config.reader release).

Summary by CodeRabbit

New Features
- Extended the public API of @pnpm/config.reader with new exports: getNetworkConfigs and getDefaultCreds functions, plus the NetworkConfigs type.

Expose the helpers that build the `configByUri` registry-config map from a flat rawConfig-style auth dict so that downstream consumers (e.g. third-party clients of `@pnpm/installing.client` / `@pnpm/store.connection-manager`) can produce the same configByUri shape pnpm itself uses, without re-implementing the parsing logic.

coderabbitai · 2026-05-05T15:01:11Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: c729d16b-42c3-4928-bd24-93b6fce3dd39

📥 Commits

Reviewing files that changed from the base of the PR and between d74ddaa and 572edd9.

📒 Files selected for processing (2)

.changeset/export-network-configs.md
config/reader/src/index.ts

📝 Walkthrough

Walkthrough

This PR exposes three previously internal utilities from @pnpm/config.reader: getNetworkConfigs, getDefaultCreds, and the NetworkConfigs type. Consumers can now import these functions to parse network authentication configurations without duplicating existing logic.

Changes

Public API Exports

Layer / File(s)	Summary
Public API Surface `config/reader/src/index.ts`	Re-exports `getDefaultCreds`, `getNetworkConfigs`, and `NetworkConfigs` type from `./getNetworkConfigs.js` to make them available to external consumers.
Release Documentation `.changeset/export-network-configs.md`	Changeset entry for `@pnpm/config.reader` minor release documents the newly exported utilities and their use case for building `configByUri` mappings.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 Three functions hop into the light,
No more hidden from the world's sight,
Parse your configs, auth so bright,
The public API grows just right! ✨

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title directly and specifically describes the main change: exporting getNetworkConfigs and getDefaultCreds from the config.reader package, which is exactly what the changeset implements.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch export-network-configs

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Copilot

Pull request overview

This PR makes existing, internally-used network/auth parsing helpers from @pnpm/config.reader available via the package’s public entrypoint, so downstream packages can build a configByUri map (and default creds) without re-implementing pnpm’s npmrc auth parsing logic.

Changes:

Re-export getNetworkConfigs, getDefaultCreds, and the NetworkConfigs type from config/reader/src/index.ts.
Add a changeset to publish @pnpm/config.reader as a minor version bump reflecting the new public exports.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
config/reader/src/index.ts	Re-exports network config helpers/types from the public module entrypoint.
.changeset/export-network-configs.md	Declares a minor release and documents the newly exported API surface.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

…1471) Expose the helpers that build the `configByUri` registry-config map from a flat rawConfig-style auth dict so that downstream consumers (e.g. third-party clients of `@pnpm/installing.client` / `@pnpm/store.connection-manager`) can produce the same configByUri shape pnpm itself uses, without re-implementing the parsing logic.

zkochan marked this pull request as ready for review May 5, 2026 15:01

Copilot AI review requested due to automatic review settings May 5, 2026 15:01

Copilot started reviewing on behalf of zkochan May 5, 2026 15:02 View session

Copilot AI reviewed May 5, 2026

View reviewed changes

zkochan merged commit 6bed8ac into main May 5, 2026
15 of 17 checks passed

zkochan deleted the export-network-configs branch May 5, 2026 16:58

coderabbitai Bot mentioned this pull request May 26, 2026

fix(config/reader): pin unscoped per-registry settings to their source's registry at load time #11953

Merged

7 tasks

coderabbitai Bot mentioned this pull request Jun 14, 2026

fix: support scope-specific registry auth tokens #12392

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

feat(config.reader): export getNetworkConfigs and getDefaultCreds#11471

feat(config.reader): export getNetworkConfigs and getDefaultCreds#11471
zkochan merged 1 commit into
mainfrom
export-network-configs

zkochan commented May 5, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented May 5, 2026 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Poem

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Uh oh!

Conversation

zkochan commented May 5, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Motivation

Test plan

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented May 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Poem

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

zkochan commented May 5, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented May 5, 2026 •

edited

Loading